Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@XilaiZhang
Copy link
Contributor

Reverts #44732

context: b/297654739
Synced with Chris and the error message is related to the PR

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 29, 2023
@auto-submit auto-submit bot merged commit 367c709 into main Aug 29, 2023
@auto-submit auto-submit bot deleted the revert-44732-remove_shared_application branch August 29, 2023 23:15
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 30, 2023
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Aug 30, 2023
…133618)

flutter/engine@9f2cf5c...749e67a

2023-08-29 [email protected] [Impeller] Document the capabilities. (flutter/engine#45253)
2023-08-29 [email protected] [flutter roll] Revert "ios: remove shared_application and support app extension build" (flutter/engine#45250)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
cyanglaz pushed a commit to cyanglaz/engine that referenced this pull request Aug 30, 2023
gaaclarke pushed a commit to gaaclarke/engine that referenced this pull request Aug 30, 2023
… extension build" (flutter#45250)

Reverts flutter#44732

context: b/297654739
Synced with Chris and the error message is related to the PR
cyanglaz pushed a commit to cyanglaz/engine that referenced this pull request Aug 31, 2023
…port app extension build" (flutter#45250)"

This reverts commit 367c709.

fix

format

tests

format
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

affects: desktop autosubmit Merge PR when tree becomes green via auto submit App platform-ios platform-macos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants