Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@zanderso
Copy link
Member

To pick up flutter/buildroot#757, which makes some sysroot paths relative.

To pick up flutter/buildroot#757, which makes some sysroot paths relative.
@zanderso zanderso requested review from dnfield and keyonghan August 29, 2023 22:04
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 29, 2023
@auto-submit auto-submit bot merged commit c8a91b2 into main Aug 29, 2023
@auto-submit auto-submit bot deleted the zanderso-patch-5 branch August 29, 2023 23:03
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 30, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 30, 2023
…133616)

flutter/engine@c5854a6...9f2cf5c

2023-08-29 [email protected] Roll Skia from 8a2754a1ae60 to e6eb56d9b074 (3 revisions) (flutter/engine#45248)
2023-08-29 [email protected] Refactor `Stopwatch` into `StopwatchVisualizer` and `SkStopwatchVisualizer` (flutter/engine#45200)
2023-08-29 [email protected] Roll buildroot (flutter/engine#45249)
2023-08-29 [email protected] [Impeller] Add GetDefaultDepthStencil to capabilities. (flutter/engine#45240)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke pushed a commit to gaaclarke/engine that referenced this pull request Aug 30, 2023
To pick up flutter/buildroot#757, which makes some sysroot paths relative.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants