This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Refactor Stopwatch into StopwatchVisualizer and SkStopwatchVisualizer
#45200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It appears this triggers golden updates, which isn't expected. Looking into now. |
matanlurey
force-pushed
the
engine-refactor-stopwatch-visualizer
branch
from
76e58d3 to
cec7eb3
Compare
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 30, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 30, 2023
…133616) flutter/engine@c5854a6...9f2cf5c 2023-08-29 [email protected] Roll Skia from 8a2754a1ae60 to e6eb56d9b074 (3 revisions) (flutter/engine#45248) 2023-08-29 [email protected] Refactor `Stopwatch` into `StopwatchVisualizer` and `SkStopwatchVisualizer` (flutter/engine#45200) 2023-08-29 [email protected] Roll buildroot (flutter/engine#45249) 2023-08-29 [email protected] [Impeller] Add GetDefaultDepthStencil to capabilities. (flutter/engine#45240) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…lizer` (flutter#45200) Partial work towards flutter/flutter#126009. Still working as before: <img width="1210" alt="Screenshot 2023-08-28 at 6 32 45 PM" src="https://github.com/flutter/engine/assets/168174/38728015-d0d4-4933-bd31-d2326c76aeee"> (There are some `PerformanceOverlayLayerDefault.*` tests that don't run locally, so I guess I'll let CI run those)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial work towards flutter/flutter#126009.
Still working as before:
(There are some
PerformanceOverlayLayerDefault.*tests that don't run locally, so I guess I'll let CI run those)