Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@itsjustkevin
Copy link
Contributor

Reverts #42362 which is causing failures in Linux Host clang_tidy blocking the release.

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@dnfield
Copy link
Contributor

dnfield commented May 31, 2023

I'm a bit confused by this. @zanderso could the failure of catching this onCI be related to what we were talking about earlier?

The fix forward for this is pretty trivial. Would it be ok to land a fix forward?

Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lint should have surfaced in presubmit. This CP is fine, and should be retained.

@dnfield dnfield mentioned this pull request May 31, 2023
@itsjustkevin
Copy link
Contributor Author

@zanderso your requested change is not visible on my end.

itsjustkevin pushed a commit that referenced this pull request May 31, 2023
Alternative to #42456

@itsjustkevin @zanderso

---------

Co-authored-by: Zachary Anderson <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants