Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented May 26, 2023

Issue: flutter/flutter#126878

Picks in #42349 and #42175

The reason for the second is that the first creates many more conflicts without it, and resolving them was a lot easier. The second PR is also very low risk and improves error messaging.

@dnfield dnfield requested review from jason-simmons and zanderso May 26, 2023 20:52
@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@zanderso
Copy link
Member

There are some build failures.

@dnfield
Copy link
Contributor Author

dnfield commented May 26, 2023

Was from a bad merge.

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2023
@auto-submit auto-submit bot merged commit c47096f into flutter:flutter-3.10-candidate.1 May 29, 2023
itsjustkevin added a commit that referenced this pull request May 31, 2023
@zanderso zanderso mentioned this pull request May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants