Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit a6436b7

Browse files
dnfieldzanderso
andauthored
Fix tidy issues (#42457)
Alternative to #42456 @itsjustkevin @zanderso --------- Co-authored-by: Zachary Anderson <[email protected]>
1 parent 186bf0f commit a6436b7

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

lib/ui/painting/image_decoder_impeller.cc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -338,6 +338,7 @@ ImageDecoderImpeller::UploadTextureToPrivate(
338338
const std::shared_ptr<impeller::Context>& context,
339339
const std::shared_ptr<impeller::DeviceBuffer>& buffer,
340340
const SkImageInfo& image_info,
341+
// NOLINTNEXTLINE(performance-unnecessary-value-param)
341342
std::shared_ptr<SkBitmap> bitmap,
342343
const std::shared_ptr<fml::SyncSwitch>& gpu_disabled_switch) {
343344
TRACE_EVENT0("impeller", __FUNCTION__);
@@ -365,6 +366,7 @@ ImageDecoderImpeller::UploadTextureToPrivate(
365366
std::pair<sk_sp<DlImage>, std::string>
366367
ImageDecoderImpeller::UploadTextureToShared(
367368
const std::shared_ptr<impeller::Context>& context,
369+
// NOLINTNEXTLINE(performance-unnecessary-value-param)
368370
std::shared_ptr<SkBitmap> bitmap,
369371
const std::shared_ptr<fml::SyncSwitch>& gpu_disabled_switch,
370372
bool create_mips) {

lib/ui/painting/image_decoder_impeller.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ class ImageDecoderImpeller final : public ImageDecoder {
8080
const std::shared_ptr<impeller::Context>& context,
8181
const std::shared_ptr<impeller::DeviceBuffer>& buffer,
8282
const SkImageInfo& image_info,
83+
// NOLINTNEXTLINE(performance-unnecessary-value-param)
8384
std::shared_ptr<SkBitmap> bitmap,
8485
const std::shared_ptr<fml::SyncSwitch>& gpu_disabled_switch);
8586

@@ -93,6 +94,7 @@ class ImageDecoderImpeller final : public ImageDecoder {
9394
/// @return A DlImage.
9495
static std::pair<sk_sp<DlImage>, std::string> UploadTextureToShared(
9596
const std::shared_ptr<impeller::Context>& context,
97+
// NOLINTNEXTLINE(performance-unnecessary-value-param)
9698
std::shared_ptr<SkBitmap> bitmap,
9799
const std::shared_ptr<fml::SyncSwitch>& gpu_disabled_switch,
98100
bool create_mips = true);

0 commit comments

Comments
 (0)