This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Make FML_LOG safe from static initialization #42219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
May 22, 2023
dnfield
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine, pr: 42219, due to - The status or check suite Linux Fuchsia FEMU has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
Author
|
Fuchsia isn't happy with the |
dnfield
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 23, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 23, 2023
…127365) flutter/engine@2a325ee...41e8d52 2023-05-23 [email protected] Make FML_LOG safe from static initialization (flutter/engine#42219) 2023-05-23 [email protected] [fuchsia] Bind ChildViewWatcher on platform thread (flutter/engine#42222) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 23, 2023
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
May 23, 2023
…sions) (#127369) Manual roll requested by [email protected] flutter/engine@a342a91...2586cbe 2023-05-23 [email protected] Revert "[ios_platform_view] only recycle maskView when the view is applying mutators #41573" (flutter/engine#42231) 2023-05-23 [email protected] Roll Skia from ac87929b3d2e to 6a57876d0e44 (2 revisions) (flutter/engine#42230) 2023-05-23 [email protected] Roll Fuchsia Mac SDK from QAwORJOkyNl4J3x4Y... to DzmjiSg6XC0JUfbKP... (flutter/engine#42227) 2023-05-23 [email protected] Manual roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42229) 2023-05-23 [email protected] Roll Skia from d448fe07ea46 to ac87929b3d2e (8 revisions) (flutter/engine#42226) 2023-05-23 [email protected] Make FML_LOG safe from static initialization (flutter/engine#42219) 2023-05-23 [email protected] [fuchsia] Bind ChildViewWatcher on platform thread (flutter/engine#42222) 2023-05-22 [email protected] Roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42224) 2023-05-22 [email protected] [Impeller] Return image decoder error messages to the Dart API (flutter/engine#42175) 2023-05-22 [email protected] Again a two-word super tiny typo (flutter/engine#42181) 2023-05-22 [email protected] Reland "[ios_platform_view] only recycle maskView when the view is applying mutators #41573" (flutter/engine#42115) 2023-05-22 [email protected] [Impeller] Use untransformed text bounds to calculate the size of ColorSourceTextContents (flutter/engine#42142) 2023-05-22 [email protected] [Impeller] Add UV compute shader. (flutter/engine#42192) 2023-05-22 [email protected] [Impeller] remove final cmd buffer waitUntilScheduled on physical iOS (flutter/engine#42160) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from QAwORJOkyNl4 to DzmjiSg6XC0J If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…lutter#127365) flutter/engine@2a325ee...41e8d52 2023-05-23 [email protected] Make FML_LOG safe from static initialization (flutter/engine#42219) 2023-05-23 [email protected] [fuchsia] Bind ChildViewWatcher on platform thread (flutter/engine#42222) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…sions) (flutter#127369) Manual roll requested by [email protected] flutter/engine@a342a91...2586cbe 2023-05-23 [email protected] Revert "[ios_platform_view] only recycle maskView when the view is applying mutators flutter#41573" (flutter/engine#42231) 2023-05-23 [email protected] Roll Skia from ac87929b3d2e to 6a57876d0e44 (2 revisions) (flutter/engine#42230) 2023-05-23 [email protected] Roll Fuchsia Mac SDK from QAwORJOkyNl4J3x4Y... to DzmjiSg6XC0JUfbKP... (flutter/engine#42227) 2023-05-23 [email protected] Manual roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42229) 2023-05-23 [email protected] Roll Skia from d448fe07ea46 to ac87929b3d2e (8 revisions) (flutter/engine#42226) 2023-05-23 [email protected] Make FML_LOG safe from static initialization (flutter/engine#42219) 2023-05-23 [email protected] [fuchsia] Bind ChildViewWatcher on platform thread (flutter/engine#42222) 2023-05-22 [email protected] Roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42224) 2023-05-22 [email protected] [Impeller] Return image decoder error messages to the Dart API (flutter/engine#42175) 2023-05-22 [email protected] Again a two-word super tiny typo (flutter/engine#42181) 2023-05-22 [email protected] Reland "[ios_platform_view] only recycle maskView when the view is applying mutators flutter#41573" (flutter/engine#42115) 2023-05-22 [email protected] [Impeller] Use untransformed text bounds to calculate the size of ColorSourceTextContents (flutter/engine#42142) 2023-05-22 [email protected] [Impeller] Add UV compute shader. (flutter/engine#42192) 2023-05-22 [email protected] [Impeller] remove final cmd buffer waitUntilScheduled on physical iOS (flutter/engine#42160) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from QAwORJOkyNl4 to DzmjiSg6XC0J If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this while trying to get some printing going for places where we're creating thread local keys.
Supposedly, just including
<iostream>should statically initializestd::cout/cerr, but it gets really hard to reason about whether your statically initialized code is going to be initialized before or after that happens. I tried making sure that the TU forfml/logging.ccdid that initialization statically, but that also failed in the verison of the test included here (it passed in some other iterations that modified run_all_unittests.cc). We could make sure it happens each and every time we touchstd::cerrbut ... we could also just usefprintf(stderr, ...)and it works just fine./cc @flar who ran into problems around this a little while back and was asking about it.