This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Use untransformed text bounds to calculate the size of ColorSourceTextContents #42142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orSourceTextContents Previously this was attempting to invert the TransformBounds done by GetCoverage. TransformBounds computes a bounding box of the transformed rectangle and can not be reversed. Fixes flutter/flutter#127103
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
|
If we don't have a golden for text with a color source, we could add one. any non-trivial transform would probably cause this issue to show up |
Closed
2 tasks
Member
|
Can we land this today and file a CP please? |
bdero
approved these changes
May 22, 2023
jason-simmons
added
the
autosubmit
jason-simmons
added a commit
to jason-simmons/flutter_engine
that referenced
this pull request
May 22, 2023
…orSourceTextContents (flutter#42142) Previously this was attempting to invert the TransformBounds done by GetCoverage. TransformBounds computes a bounding box of the transformed rectangle and can not be reversed. Fixes flutter/flutter#127103
Member
|
@jason-simmons Is it possible to follow up on @jonahwilliams's suggestion of a golden test in a subsequent PR? |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2023
…ize of ColorSourceTextContents (flutter/engine#42142)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 23, 2023
…ize of ColorSourceTextContents (flutter/engine#42142)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 23, 2023
…127364) flutter/engine@a342a91...2a325ee 2023-05-22 [email protected] Roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42224) 2023-05-22 [email protected] [Impeller] Return image decoder error messages to the Dart API (flutter/engine#42175) 2023-05-22 [email protected] Again a two-word super tiny typo (flutter/engine#42181) 2023-05-22 [email protected] Reland "[ios_platform_view] only recycle maskView when the view is applying mutators #41573" (flutter/engine#42115) 2023-05-22 [email protected] [Impeller] Use untransformed text bounds to calculate the size of ColorSourceTextContents (flutter/engine#42142) 2023-05-22 [email protected] [Impeller] Add UV compute shader. (flutter/engine#42192) 2023-05-22 [email protected] [Impeller] remove final cmd buffer waitUntilScheduled on physical iOS (flutter/engine#42160) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 23, 2023
…ize of ColorSourceTextContents (flutter/engine#42142)
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
May 23, 2023
…sions) (#127369) Manual roll requested by [email protected] flutter/engine@a342a91...2586cbe 2023-05-23 [email protected] Revert "[ios_platform_view] only recycle maskView when the view is applying mutators #41573" (flutter/engine#42231) 2023-05-23 [email protected] Roll Skia from ac87929b3d2e to 6a57876d0e44 (2 revisions) (flutter/engine#42230) 2023-05-23 [email protected] Roll Fuchsia Mac SDK from QAwORJOkyNl4J3x4Y... to DzmjiSg6XC0JUfbKP... (flutter/engine#42227) 2023-05-23 [email protected] Manual roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42229) 2023-05-23 [email protected] Roll Skia from d448fe07ea46 to ac87929b3d2e (8 revisions) (flutter/engine#42226) 2023-05-23 [email protected] Make FML_LOG safe from static initialization (flutter/engine#42219) 2023-05-23 [email protected] [fuchsia] Bind ChildViewWatcher on platform thread (flutter/engine#42222) 2023-05-22 [email protected] Roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42224) 2023-05-22 [email protected] [Impeller] Return image decoder error messages to the Dart API (flutter/engine#42175) 2023-05-22 [email protected] Again a two-word super tiny typo (flutter/engine#42181) 2023-05-22 [email protected] Reland "[ios_platform_view] only recycle maskView when the view is applying mutators #41573" (flutter/engine#42115) 2023-05-22 [email protected] [Impeller] Use untransformed text bounds to calculate the size of ColorSourceTextContents (flutter/engine#42142) 2023-05-22 [email protected] [Impeller] Add UV compute shader. (flutter/engine#42192) 2023-05-22 [email protected] [Impeller] remove final cmd buffer waitUntilScheduled on physical iOS (flutter/engine#42160) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from QAwORJOkyNl4 to DzmjiSg6XC0J If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…lutter#127364) flutter/engine@a342a91...2a325ee 2023-05-22 [email protected] Roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42224) 2023-05-22 [email protected] [Impeller] Return image decoder error messages to the Dart API (flutter/engine#42175) 2023-05-22 [email protected] Again a two-word super tiny typo (flutter/engine#42181) 2023-05-22 [email protected] Reland "[ios_platform_view] only recycle maskView when the view is applying mutators flutter#41573" (flutter/engine#42115) 2023-05-22 [email protected] [Impeller] Use untransformed text bounds to calculate the size of ColorSourceTextContents (flutter/engine#42142) 2023-05-22 [email protected] [Impeller] Add UV compute shader. (flutter/engine#42192) 2023-05-22 [email protected] [Impeller] remove final cmd buffer waitUntilScheduled on physical iOS (flutter/engine#42160) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…sions) (flutter#127369) Manual roll requested by [email protected] flutter/engine@a342a91...2586cbe 2023-05-23 [email protected] Revert "[ios_platform_view] only recycle maskView when the view is applying mutators flutter#41573" (flutter/engine#42231) 2023-05-23 [email protected] Roll Skia from ac87929b3d2e to 6a57876d0e44 (2 revisions) (flutter/engine#42230) 2023-05-23 [email protected] Roll Fuchsia Mac SDK from QAwORJOkyNl4J3x4Y... to DzmjiSg6XC0JUfbKP... (flutter/engine#42227) 2023-05-23 [email protected] Manual roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42229) 2023-05-23 [email protected] Roll Skia from d448fe07ea46 to ac87929b3d2e (8 revisions) (flutter/engine#42226) 2023-05-23 [email protected] Make FML_LOG safe from static initialization (flutter/engine#42219) 2023-05-23 [email protected] [fuchsia] Bind ChildViewWatcher on platform thread (flutter/engine#42222) 2023-05-22 [email protected] Roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42224) 2023-05-22 [email protected] [Impeller] Return image decoder error messages to the Dart API (flutter/engine#42175) 2023-05-22 [email protected] Again a two-word super tiny typo (flutter/engine#42181) 2023-05-22 [email protected] Reland "[ios_platform_view] only recycle maskView when the view is applying mutators flutter#41573" (flutter/engine#42115) 2023-05-22 [email protected] [Impeller] Use untransformed text bounds to calculate the size of ColorSourceTextContents (flutter/engine#42142) 2023-05-22 [email protected] [Impeller] Add UV compute shader. (flutter/engine#42192) 2023-05-22 [email protected] [Impeller] remove final cmd buffer waitUntilScheduled on physical iOS (flutter/engine#42160) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from QAwORJOkyNl4 to DzmjiSg6XC0J If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jason-simmons
added a commit
to jason-simmons/flutter_engine
that referenced
this pull request
May 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was attempting to invert the TransformBounds done by GetCoverage. TransformBounds computes a bounding box of the transformed rectangle and can not be reversed.
Fixes flutter/flutter#127103