This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Add UV compute shader. #42192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
commented
May 20, 2023
Comment on lines
+971
to
+975
| DeviceBufferDescriptor buffer_desc; | ||
| buffer_desc.size = total * sizeof(Point); | ||
| buffer_desc.storage_mode = StorageMode::kDevicePrivate; | ||
|
|
||
| auto geometry_buffer = renderer.GetContext() |
Contributor
Author
There was a problem hiding this comment.
Small discovery, if I use buffers allocated from the compute passes transients buffer, then the second compute pass doesn't correctly synchronize on the completion on the first. I suspect metal is tracking buffer inputs/outputs to do automatic fences and the singular buffer defeats that detection.
chinmaygarde
changed the title
jonahwilliams
commented
May 22, 2023
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| #include <impeller/texture.glsl> |
Contributor
Author
There was a problem hiding this comment.
This isn't specific to draw points and can be used with any of our geometries.
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
dnfield
approved these changes
May 22, 2023
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
Flutter: The fastest way to draw points anywhere?
This makes me think I should start looking at getting compute going on Vulkan next.
LGTM
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 23, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 23, 2023
…127364) flutter/engine@a342a91...2a325ee 2023-05-22 [email protected] Roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42224) 2023-05-22 [email protected] [Impeller] Return image decoder error messages to the Dart API (flutter/engine#42175) 2023-05-22 [email protected] Again a two-word super tiny typo (flutter/engine#42181) 2023-05-22 [email protected] Reland "[ios_platform_view] only recycle maskView when the view is applying mutators #41573" (flutter/engine#42115) 2023-05-22 [email protected] [Impeller] Use untransformed text bounds to calculate the size of ColorSourceTextContents (flutter/engine#42142) 2023-05-22 [email protected] [Impeller] Add UV compute shader. (flutter/engine#42192) 2023-05-22 [email protected] [Impeller] remove final cmd buffer waitUntilScheduled on physical iOS (flutter/engine#42160) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 23, 2023
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
May 23, 2023
…sions) (#127369) Manual roll requested by [email protected] flutter/engine@a342a91...2586cbe 2023-05-23 [email protected] Revert "[ios_platform_view] only recycle maskView when the view is applying mutators #41573" (flutter/engine#42231) 2023-05-23 [email protected] Roll Skia from ac87929b3d2e to 6a57876d0e44 (2 revisions) (flutter/engine#42230) 2023-05-23 [email protected] Roll Fuchsia Mac SDK from QAwORJOkyNl4J3x4Y... to DzmjiSg6XC0JUfbKP... (flutter/engine#42227) 2023-05-23 [email protected] Manual roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42229) 2023-05-23 [email protected] Roll Skia from d448fe07ea46 to ac87929b3d2e (8 revisions) (flutter/engine#42226) 2023-05-23 [email protected] Make FML_LOG safe from static initialization (flutter/engine#42219) 2023-05-23 [email protected] [fuchsia] Bind ChildViewWatcher on platform thread (flutter/engine#42222) 2023-05-22 [email protected] Roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42224) 2023-05-22 [email protected] [Impeller] Return image decoder error messages to the Dart API (flutter/engine#42175) 2023-05-22 [email protected] Again a two-word super tiny typo (flutter/engine#42181) 2023-05-22 [email protected] Reland "[ios_platform_view] only recycle maskView when the view is applying mutators #41573" (flutter/engine#42115) 2023-05-22 [email protected] [Impeller] Use untransformed text bounds to calculate the size of ColorSourceTextContents (flutter/engine#42142) 2023-05-22 [email protected] [Impeller] Add UV compute shader. (flutter/engine#42192) 2023-05-22 [email protected] [Impeller] remove final cmd buffer waitUntilScheduled on physical iOS (flutter/engine#42160) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from QAwORJOkyNl4 to DzmjiSg6XC0J If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…lutter#127364) flutter/engine@a342a91...2a325ee 2023-05-22 [email protected] Roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42224) 2023-05-22 [email protected] [Impeller] Return image decoder error messages to the Dart API (flutter/engine#42175) 2023-05-22 [email protected] Again a two-word super tiny typo (flutter/engine#42181) 2023-05-22 [email protected] Reland "[ios_platform_view] only recycle maskView when the view is applying mutators flutter#41573" (flutter/engine#42115) 2023-05-22 [email protected] [Impeller] Use untransformed text bounds to calculate the size of ColorSourceTextContents (flutter/engine#42142) 2023-05-22 [email protected] [Impeller] Add UV compute shader. (flutter/engine#42192) 2023-05-22 [email protected] [Impeller] remove final cmd buffer waitUntilScheduled on physical iOS (flutter/engine#42160) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…sions) (flutter#127369) Manual roll requested by [email protected] flutter/engine@a342a91...2586cbe 2023-05-23 [email protected] Revert "[ios_platform_view] only recycle maskView when the view is applying mutators flutter#41573" (flutter/engine#42231) 2023-05-23 [email protected] Roll Skia from ac87929b3d2e to 6a57876d0e44 (2 revisions) (flutter/engine#42230) 2023-05-23 [email protected] Roll Fuchsia Mac SDK from QAwORJOkyNl4J3x4Y... to DzmjiSg6XC0JUfbKP... (flutter/engine#42227) 2023-05-23 [email protected] Manual roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42229) 2023-05-23 [email protected] Roll Skia from d448fe07ea46 to ac87929b3d2e (8 revisions) (flutter/engine#42226) 2023-05-23 [email protected] Make FML_LOG safe from static initialization (flutter/engine#42219) 2023-05-23 [email protected] [fuchsia] Bind ChildViewWatcher on platform thread (flutter/engine#42222) 2023-05-22 [email protected] Roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42224) 2023-05-22 [email protected] [Impeller] Return image decoder error messages to the Dart API (flutter/engine#42175) 2023-05-22 [email protected] Again a two-word super tiny typo (flutter/engine#42181) 2023-05-22 [email protected] Reland "[ios_platform_view] only recycle maskView when the view is applying mutators flutter#41573" (flutter/engine#42115) 2023-05-22 [email protected] [Impeller] Use untransformed text bounds to calculate the size of ColorSourceTextContents (flutter/engine#42142) 2023-05-22 [email protected] [Impeller] Add UV compute shader. (flutter/engine#42192) 2023-05-22 [email protected] [Impeller] remove final cmd buffer waitUntilScheduled on physical iOS (flutter/engine#42160) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from QAwORJOkyNl4 to DzmjiSg6XC0J If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a compute shader that computes the UV mapping for an arbitrary geometry. Use it with drawPoints since I didn't realize it was possible to use an image shader with this 😆 .