This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove unused setPersistentIsolateData function #30795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
gaaclarke
approved these changes
Jan 11, 2022
Member
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
lgtm, i didn't see usage in the engine and usage outside of the engine would be an unsupported hack.
Contributor
|
test-exempt: only code removal |
ColdPaleLight
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 11, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 12, 2022
* f5ebc91 Roll Fuchsia Linux SDK from DS-3oCidC... to 3-zk7OPWY... (flutter/engine#30792) * 1064abe Roll Skia from 7a14f783bda3 to 41e994f735d9 (2 revisions) (flutter/engine#30793) * a4a505b Revert "Roll Fuchsia Linux SDK from DS-3oCidC... to 3-zk7OPWY... (#30792)" (flutter/engine#30798) * 6389ee3 [fuchsia] Bump buildroot/ to fix Fuchsia SDK roll (flutter/engine#30794) * f94c8e0 Implemented library uri support for FlutterFragmentActivities (flutter/engine#30790) * c180748 Roll Fuchsia Mac SDK from 9rr72kcgt... to LxyiyZWks... (flutter/engine#30796) * 6927c00 Roll Dart SDK from 3061b1d4c117 to 099f7f57767c (5 revisions) (flutter/engine#30797) * d889c0c Roll Skia from 41e994f735d9 to 345587df72ae (3 revisions) (flutter/engine#30800) * d53514e Remove unused setPersistentIsolateData function (flutter/engine#30795) * f1b4548 Variable Refresh Rate Display (flutter/engine#30223) * 0139f6e Roll Skia from 345587df72ae to 30fdea3d8fd5 (2 revisions) (flutter/engine#30802) * 643b278 Add 'keyCode' field to eventData map created from html keyboard events. (flutter/engine#30801)
JsouLiang
pushed a commit
to JsouLiang/engine
that referenced
this pull request
Jan 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FlutterDartProject.setPersistentIsolateDatais neither a public API nor is it used anywhere internally. And its purpose is easily misunderstood by contributors.It seems that there was a plan to use persistent isolate data to store some persistent data such as user settings data and lifecycle state, but we never started doing it.
Even if we need to use it to store user settings data and lifecycle state in the future, we still should not set it by
FlutterDartProject.setPersistentIsolateData, because lightweight engines share the sameFlutterDartProject, while each engine needs to have its own settings data and lifecycle state. SoRunConfigurationwould be a better choice thanFlutterDartProject.setPersistentIsolateData.Pre-launch Checklist
writing and running engine tests.
///).