This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Variable Refresh Rate Display #30223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Contributor
Author
|
friendly ping @dnfield @iskakaushik :) |
iskakaushik
reviewed
Jan 4, 2022
shell/common/display.h
Outdated
| #include <optional> | ||
|
|
||
| #include "flutter/fml/macros.h" | ||
| #include "variable_refresh_rate_reporter.h" |
Contributor
There was a problem hiding this comment.
nit: full path for the include.
shell/common/engine.h
Outdated
| return runtime_controller_.get(); | ||
| } | ||
|
|
||
| const std::shared_ptr<VsyncWaiter> GetVsyncWaiter() const; |
Contributor
There was a problem hiding this comment.
given that engine will outlive the vsync waiter, can we hand a reference rather than handing out a shared pointer.
shell/common/vsync_waiters_test.h
Outdated
| void UpdateRefreshRate(double refresh_rate); | ||
|
|
||
| // |RefreshRateReporter| | ||
| double GetRefreshRate() override; |
Member
|
Any updates on @iskakaushik s queries? |
Contributor
Author
|
@chinmaygarde I was sick the last several days. I'm currently looking into another issue and will update this asap. |
added 4 commits
January 10, 2022 10:08
cyanglaz
commented
Jan 10, 2022
Contributor
Author
cyanglaz
left a comment
cyanglaz
left a comment
There was a problem hiding this comment.
@iskakaushik Updated based on your review comments! PTAL.
shell/common/display.h
Outdated
| #include <optional> | ||
|
|
||
| #include "flutter/fml/macros.h" | ||
| #include "variable_refresh_rate_reporter.h" |
shell/common/engine.h
Outdated
| return runtime_controller_.get(); | ||
| } | ||
|
|
||
| const std::shared_ptr<VsyncWaiter> GetVsyncWaiter() const; |
shell/common/vsync_waiters_test.h
Outdated
| void UpdateRefreshRate(double refresh_rate); | ||
|
|
||
| // |RefreshRateReporter| | ||
| double GetRefreshRate() override; |
iskakaushik
reviewed
Jan 11, 2022
| namespace testing { | ||
|
|
||
| TEST(VariableRefreshRateDisplayTest, ReportCorrectInitialRefreshRate) { | ||
| auto refresh_rate_reporter = std::make_shared<TestRefreshRateReporter>(60); |
Contributor
There was a problem hiding this comment.
nit: no need for make shared in these tests anymore.
cyanglaz
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 11, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 12, 2022
* f5ebc91 Roll Fuchsia Linux SDK from DS-3oCidC... to 3-zk7OPWY... (flutter/engine#30792) * 1064abe Roll Skia from 7a14f783bda3 to 41e994f735d9 (2 revisions) (flutter/engine#30793) * a4a505b Revert "Roll Fuchsia Linux SDK from DS-3oCidC... to 3-zk7OPWY... (#30792)" (flutter/engine#30798) * 6389ee3 [fuchsia] Bump buildroot/ to fix Fuchsia SDK roll (flutter/engine#30794) * f94c8e0 Implemented library uri support for FlutterFragmentActivities (flutter/engine#30790) * c180748 Roll Fuchsia Mac SDK from 9rr72kcgt... to LxyiyZWks... (flutter/engine#30796) * 6927c00 Roll Dart SDK from 3061b1d4c117 to 099f7f57767c (5 revisions) (flutter/engine#30797) * d889c0c Roll Skia from 41e994f735d9 to 345587df72ae (3 revisions) (flutter/engine#30800) * d53514e Remove unused setPersistentIsolateData function (flutter/engine#30795) * f1b4548 Variable Refresh Rate Display (flutter/engine#30223) * 0139f6e Roll Skia from 345587df72ae to 30fdea3d8fd5 (2 revisions) (flutter/engine#30802) * 643b278 Add 'keyCode' field to eventData map created from html keyboard events. (flutter/engine#30801)
JsouLiang
pushed a commit
to JsouLiang/engine
that referenced
this pull request
Jan 14, 2022
Member
|
@cyanglaz maybe we can also let Android also use this |
Contributor
Author
|
@eggfly Yes, I think it can. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new VariableRefreshRateDisplay, which replies on a VariableRefreshRateReporter to dynamically report refresh rate.
Make VsyncWaiterIOS a VariableRefreshRateReporter that reports the refresh rate dynamically.
Fixes flutter/flutter#94507
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.