Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@ColdPaleLight
Copy link
Member

@ColdPaleLight ColdPaleLight commented Jan 11, 2022

Since the superclass of FlutterFragmentActivity is FragmentActivity instead of FlutterActivity, It seems that we still need to add this feature to FlutterFragmentActivity :-)

related issue : flutter/flutter#91841
related PR : #30726

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaaclarke gaaclarke merged commit f94c8e0 into flutter:main Jan 11, 2022
zanderso pushed a commit to flutter/flutter that referenced this pull request Jan 12, 2022
* f5ebc91 Roll Fuchsia Linux SDK from DS-3oCidC... to 3-zk7OPWY... (flutter/engine#30792)

* 1064abe Roll Skia from 7a14f783bda3 to 41e994f735d9 (2 revisions) (flutter/engine#30793)

* a4a505b Revert "Roll Fuchsia Linux SDK from DS-3oCidC... to 3-zk7OPWY... (#30792)" (flutter/engine#30798)

* 6389ee3 [fuchsia] Bump buildroot/ to fix Fuchsia SDK roll (flutter/engine#30794)

* f94c8e0 Implemented library uri support for FlutterFragmentActivities (flutter/engine#30790)

* c180748 Roll Fuchsia Mac SDK from 9rr72kcgt... to LxyiyZWks... (flutter/engine#30796)

* 6927c00 Roll Dart SDK from 3061b1d4c117 to 099f7f57767c (5 revisions) (flutter/engine#30797)

* d889c0c Roll Skia from 41e994f735d9 to 345587df72ae (3 revisions) (flutter/engine#30800)

* d53514e Remove unused setPersistentIsolateData function (flutter/engine#30795)

* f1b4548 Variable Refresh Rate Display (flutter/engine#30223)

* 0139f6e Roll Skia from 345587df72ae to 30fdea3d8fd5 (2 revisions) (flutter/engine#30802)

* 643b278 Add 'keyCode' field to eventData map created from html keyboard events. (flutter/engine#30801)
JsouLiang pushed a commit to JsouLiang/engine that referenced this pull request Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants