This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] consolidate JS interop code (attempt 2) #30161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original flutter#30007 was reverted because it broke the framework. Turns out the framework still used the WebExperiments code, which has been cleaned up in flutter/flutter#94739. This PR must land after flutter/flutter#94739. This reverts commit bd3a394.
mdebbar
approved these changes
Dec 6, 2021
yjbanov
added
the
waiting for tree to go green
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
mdebbar
added
the
waiting for tree to go green
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
Contributor
Author
|
Landing despite the Windows bot flakiness. This PR is web-only. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original #30007 was reverted because it broke the framework. Turns out the framework still used the WebExperiments code, which has been cleaned up in flutter/flutter#94739.
This PR must land after flutter/flutter#94739.
This reverts commit bd3a394.
There are no manual changes in this PR. This is a pure
git revert.