This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] consolidate JS interop code #30007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
mdebbar
reviewed
Dec 1, 2021
yjbanov
force-pushed
the
js-interop-consolidation
branch
from
9215e41 to
2a1efdb
Compare
mdebbar
approved these changes
Dec 2, 2021
mdebbar
approved these changes
Dec 2, 2021
| // added by this script during the rewrite. | ||
| void _validateEngineSource(String engineDartPath, String engineDartCode) { | ||
| const List<String> expectedLines = <String>[ | ||
| 'library engine;', |
There was a problem hiding this comment.
I was bitten before by having a different number of spaces. That's why I added \s+ to many regexes above. Maybe turn this into a list of regexes?
Another issue that I can think of is this line could have a trailing comment in the source code:
library engine; // some comment here.Could also be fixed if we use a list of regexes.
If you think this is overkill now, you can just leave it as is. We can always fix it in the future if it becomes a problem.
There was a problem hiding this comment.
I'm guessing for this particular line it probably doesn't matter. But I agree, for code that's more malleable that could be annoying.
Comment on lines
+38
to
+51
| @JS() | ||
| library dart._engine; | ||
| import 'dart:async'; | ||
| import 'dart:collection'; | ||
| import 'dart:convert' hide Codec; | ||
| import 'dart:developer' as developer; | ||
| import 'dart:html' as html; | ||
| import 'dart:js' as js; | ||
| import 'dart:js_util' as js_util; | ||
| import 'dart:_js_annotations'; | ||
| import 'dart:math' as math; | ||
| import 'dart:svg' as svg; | ||
| import 'dart:typed_data'; |
There was a problem hiding this comment.
Btw, this change is expected fail sdk_rewriter_test.dart. So the tests need to be updated as well.
yjbanov
force-pushed
the
js-interop-consolidation
branch
from
d37e94f to
94d137e
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 4, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 4, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 4, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 4, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 4, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 4, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 4, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 4, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 5, 2021
flar
added a commit
that referenced
this pull request
Dec 5, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 5, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 5, 2021
yjbanov
added a commit
to yjbanov/engine
that referenced
this pull request
Dec 6, 2021
The original flutter#30007 was reverted because it broke the framework. Turns out the framework still used the WebExperiments code, which has been cleaned up in flutter/flutter#94739. This PR must land after flutter/flutter#94739. This reverts commit bd3a394.
yjbanov
added a commit
that referenced
this pull request
Dec 7, 2021
The original #30007 was reverted because it broke the framework. Turns out the framework still used the WebExperiments code, which has been cleaned up in flutter/flutter#94739. This PR must land after flutter/flutter#94739. This reverts commit bd3a394.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
canvaskit_api.dart- interop with CanvasKit APIsafe_browser_api.dart- interop with browser APIs that can't be accessed normally viadart:html,dart:svg, ordart:webgl.js_access_test.dartthat:engine.dartis exclusively an import/export library (there's no functional code in it)