Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Move ui files to lib/ #30051

Merged
merged 12 commits into from
Jan 14, 2022
Merged

[web] Move ui files to lib/ #30051

merged 12 commits into from
Jan 14, 2022

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Dec 1, 2021 •
edited
Loading

Wait for #30007 (being relanded in #30161).

@mdebbar mdebbar added the platform-web Code specifically for the web engine label Dec 1, 2021
@mdebbar mdebbar requested a review from yjbanov December 1, 2021 21:34
@flutter-dashboard
Copy link

flutter-dashboard bot commented Dec 1, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Dec 1, 2021
yjbanov
yjbanov approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@flutter-dashboard
Copy link

flutter-dashboard bot commented Jan 12, 2022

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

@mdebbar mdebbar added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 14, 2022
@fluttergithubbot fluttergithubbot merged commit 36b44a2 into flutter:main Jan 14, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 15, 2022
@engine-flutter-autoroll
36b44a2 [web] Move ui files to lib/ (flutter/engine#30051)
0d9bfc7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 15, 2022
@engine-flutter-autoroll
36b44a2 [web] Move ui files to lib/ (flutter/engine#30051)
6853b7c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 18, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 18, 2022
@engine-flutter-autoroll
36b44a2 [web] Move ui files to lib/ (flutter/engine#30051)
8112c6a
@mdebbar mdebbar mentioned this pull request Jan 19, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@yjbanov yjbanov yjbanov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes needs tests platform-android platform-web Code specifically for the web engine waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdebbar @yjbanov @fluttergithubbot