This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Update general_golden_test.dart #30134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flar
reviewed
Dec 4, 2021
| test('foreground style (DOM)', () { | ||
| const Rect bounds = Rect.fromLTWH(0, 0, 300, 200); | ||
| final DomCanvas canvas = DomCanvas(domRenderer.createElement('flt-picture')); | ||
| final DomCanvas canvas = DomCanvas(html.document.createElement('flt-picture')); |
Contributor
There was a problem hiding this comment.
This does not match the way that domRenderer was replaced in other fixes that I've seen. I am not familiar enough with this code to approve this fix.
Contributor
Author
There was a problem hiding this comment.
This method was removed from domRenderer. Other fixes you've seen probably involve different methods that remained on the class.
Contributor
Author
There was a problem hiding this comment.
jason-simmons
approved these changes
Dec 4, 2021
mdebbar
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 5, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 5, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.