Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Update general_golden_test.dart #30134

Merged
merged 1 commit into from
Dec 5, 2021
Merged

Update general_golden_test.dart #30134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/web_ui/test/html/paragraph/general_golden_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,7 +536,7 @@ Future<void> testMain() async {

test('foreground style (DOM)', () {
const Rect bounds = Rect.fromLTWH(0, 0, 300, 200);
final DomCanvas canvas = DomCanvas(domRenderer.createElement('flt-picture'));
final DomCanvas canvas = DomCanvas(html.document.createElement('flt-picture'));
Copy link
Contributor

@flar flar Dec 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not match the way that domRenderer was replaced in other fixes that I've seen. I am not familiar enough with this code to approve this fix.

Copy link
Contributor Author

@mdebbar mdebbar Dec 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method was removed from domRenderer. Other fixes you've seen probably involve different methods that remained on the class.

Copy link
Contributor Author

@mdebbar mdebbar Dec 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/flutter/engine/pull/29994/files#diff-2e397fe99783ca804ffb22101a29c454c83dac5787deb1b57863a73429690d49

testForegroundStyle(canvas);
return takeScreenshot(canvas, bounds, 'canvas_paragraph_foreground_style_dom');
});
Expand Down