Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@flar
Copy link
Contributor

@flar flar commented Dec 4, 2021

Reverts #29888 which was breaking the engine builds due to a reference to the undefined "domRenderer".

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Dec 4, 2021
@google-cla google-cla bot added the cla: yes label Dec 4, 2021
Copy link
Contributor

@GaryQian GaryQian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@flar flar added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Dec 4, 2021
@mdebbar
Copy link
Contributor

mdebbar commented Dec 4, 2021

Please don't revert. I'll fix it now.

@mdebbar mdebbar removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Dec 4, 2021
@mdebbar
Copy link
Contributor

mdebbar commented Dec 4, 2021

#30134

@flar flar closed this Dec 5, 2021
@chinmaygarde chinmaygarde deleted the revert-29888-text-style-foreground branch December 6, 2021 23:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants