-
Notifications
You must be signed in to change notification settings - Fork 6k
[web] Fixing text foreground paint / stroke for HTML web-renderer #29888
[web] Fixing text foreground paint / stroke for HTML web-renderer #29888
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@googlebot I fixed it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing this! I think this PR is almost ready to go after some minor suggestions are fixed.
|
Thank you for your helpful suggestions! 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! This PR looks good to me with only 2 minor suggestions.
Once the goldens PR is merged, you should update the goldens_lock.yaml file to point to the new SHA in the flutter/goldens repo.
|
@abelokon0711 I'm unable to add new commits to this PR. Could you please make sure that you checked the "Allow edits by maintainers" box? |
|
@mdebbar It's checked now 👍 Sorry for the inconvenience |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this great contribution!
|
This PR is breaking the builds due to the undefined name "domRenderer". See #30038 for a potential fix. |
This PR adds missing text stroke support when using the DOM and bitmap canvas by evaluating the TextStyle 'foreground' property.
On the DOM canvas it creates the corresponding CSS text stroke style. On the bitmap canvas it uses the HTML canvas strokeText method.
Fixes #46683.
Is there a particular reason why in the current implementation the 'foreground' property is not used for painting text strokes in the HTML renderer?
Goldens: flutter/goldens#230