Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Dec 1, 2021

Pick up flutter/web_installers#29 to support upgrading iOS simulator devices and SDK on builder.
flutter/flutter#85555

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Dec 1, 2021
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Dec 1, 2021
@google-cla google-cla bot added the cla: yes label Dec 1, 2021
@jmagman
Copy link
Member Author

jmagman commented Dec 1, 2021

test: felt ios-safari test passed: https://ci.chromium.org/p/flutter/builders/try/Mac%20Web%20Engine/21326?

@jmagman jmagman requested a review from yjbanov December 1, 2021 17:52
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmagman jmagman added waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. and removed waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. labels Dec 1, 2021
@jmagman jmagman force-pushed the web-installer-roll branch 3 times, most recently from 218f9ed to 4c5251f Compare December 1, 2021 18:56
@jmagman
Copy link
Member Author

jmagman commented Dec 1, 2021

(the force pushing churn is from trying to find a parent commit without unrelated presubmit failures so I can push this change when the tree goes green without additional rebasing)

@jmagman jmagman force-pushed the web-installer-roll branch from 4c5251f to aa24efe Compare December 1, 2021 19:37
@jmagman jmagman added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Dec 2, 2021
@fluttergithubbot fluttergithubbot merged commit 476ed30 into flutter:main Dec 2, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 2, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 2, 2021
flar added a commit that referenced this pull request Dec 2, 2021
zanderso pushed a commit to flutter/flutter that referenced this pull request Dec 2, 2021
* 9b200e1 Roll Dart SDK from 9f61c2487bbd to 3a963ff14181 (7 revisions) (flutter/engine#30011)

* fada035 Use WindowInfoTracker.Companion.getOrCreate instead of the short version (flutter/engine#30012)

* d280475 Non painting platform views (flutter/engine#30003)

* b420c16 [macOS] MacOS Keyboard properly handles multi-char characters (flutter/engine#30005)

* 0a6098b [Win32, keyboard] Fix dead key events that don't have the dead key mask (flutter/engine#30004)

* 8ac9366 Fix sceneElement analysis error (flutter/engine#30038)

* 5ad06c2 Share the io_manager between parent and spawn engine (flutter/engine#29915)

* 69be405 Run Dart VM tasks on the engine's ConcurrentMessageLoop instead the VM's separate thread pool. (flutter/engine#29819)

* c85a129 Roll Dart SDK from 3a963ff14181 to 8bb2e56ec900 (4 revisions) (flutter/engine#30045)

* abf6c34 Eliminate hardcoded scale factor in a11y scroll (flutter/engine#30013)

* d184d9b Roll Skia from fa183572bfd3 to d3399178196e (17 revisions) (flutter/engine#30047)

* 476ed30 Roll web_installers simulators package (flutter/engine#30035)

* 62113c4 Revert dart to 9f61c2487bbd (flutter/engine#30056)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes platform-web Code specifically for the web engine waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants