Skip to content
This repository was archived by the owner on Nov 29, 2023. It is now read-only.

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Dec 1, 2021

When simulator runtime or devices are not found, print the failing output to show what simulators are available. Useful for LUCI Xcode cipd package introspection.

Will help figure out what simulators are available when upgrading Xcode on the builders:
https://logs.chromium.org/logs/flutter/led/magder_google.com/5e74b39e0a9f1bdc682c8d81f3d8baca2431d9547882e7eaf9cbde48e89daf9b/+/u/test:_felt_ios-safari_test/stdout

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@jmagman jmagman self-assigned this Dec 1, 2021
@jmagman jmagman requested a review from yjbanov December 1, 2021 08:27
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmagman jmagman merged commit 9afed28 into flutter:master Dec 1, 2021
@jmagman jmagman deleted the sim-print branch December 1, 2021 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants