This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Eliminate hardcoded scale factor in a11y scroll #30013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
This code is a very thin veneer on Win32 APIs that aren't conveniently mockable. I did break out the enum -> float conversion function so I could move this to a utils file and write a test for that one function. |
|
Yanked it out into its own utility in |
When performing an accessibilty scroll, the default scroll distance is kSmallScrollIncrement (40 pixels). This value is then multiplied by the system scale factor, as set in the display settings drop-down in the Windows system settings. When we imported the AX tree from Chromium, we hard-coded the system scale factor to 1.0 due to a fair amount of abstraction of the scale factor lookup in their code. This fills it back in. Issue: flutter/flutter#78798
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 1, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 1, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 2, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 2, 2021
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 2, 2021
* 9b200e1 Roll Dart SDK from 9f61c2487bbd to 3a963ff14181 (7 revisions) (flutter/engine#30011) * fada035 Use WindowInfoTracker.Companion.getOrCreate instead of the short version (flutter/engine#30012) * d280475 Non painting platform views (flutter/engine#30003) * b420c16 [macOS] MacOS Keyboard properly handles multi-char characters (flutter/engine#30005) * 0a6098b [Win32, keyboard] Fix dead key events that don't have the dead key mask (flutter/engine#30004) * 8ac9366 Fix sceneElement analysis error (flutter/engine#30038) * 5ad06c2 Share the io_manager between parent and spawn engine (flutter/engine#29915) * 69be405 Run Dart VM tasks on the engine's ConcurrentMessageLoop instead the VM's separate thread pool. (flutter/engine#29819) * c85a129 Roll Dart SDK from 3a963ff14181 to 8bb2e56ec900 (4 revisions) (flutter/engine#30045) * abf6c34 Eliminate hardcoded scale factor in a11y scroll (flutter/engine#30013) * d184d9b Roll Skia from fa183572bfd3 to d3399178196e (17 revisions) (flutter/engine#30047) * 476ed30 Roll web_installers simulators package (flutter/engine#30035) * 62113c4 Revert dart to 9f61c2487bbd (flutter/engine#30056)
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing an accessibilty scroll, the default scroll distance is
kSmallScrollIncrement (40 pixels). This value is then multiplied by the
system scale factor, as set in the display settings drop-down in the Windows
system settings.
When we imported the AX tree from Chromium, we hard-coded the system
scale factor to 1.0 due to a fair amount of abstraction of the scale
factor lookup in their code. This fills it back in.
Issue: flutter/flutter#78798
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.