Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Roll Dart SDK from 2a693f47e303 to 6fecad447467 (1 revision)" #28309

Merged
Parent: Master
merged 1 commit into from
Aug 25, 2021
Merged

Revert "Roll Dart SDK from 2a693f47e303 to 6fecad447467 (1 revision)" #28309

merged 1 commit into from
Aug 25, 2021

Conversation

@zanderso
Copy link
Member

Reverts #28301

Changed error message from the front-end is blocking rolls into the framework. See

flutter/flutter#88891

@google-cla google-cla bot added the cla: yes label Aug 25, 2021
@zanderso zanderso requested a review from cbracken August 25, 2021 20:14
@zanderso
Copy link
Member Author 

10:21 +20 ~2 -1: test/web.shard/expression_evaluation_web_test.dart: Flutter run for web can handle compilation errors [E]                                                                             
  Expected: <Instance of 'ErrorRef'> with `message`: 'CompilationError: Getter not found: \'typo\'.\n'
              'typo\n'
              '^^^^'
    Actual: ErrorRef:<[ErrorRef id: 587, kind: error, message: CompilationError: Undefined name 'typo'.
            typo
            ^^^^]>
     Which: has `message` with value 'CompilationError: Undefined name \'typo\'.\n'
              'typo\n'
              '^^^^' which is different.
            Expected: ... ionError: Getter not ...
              Actual: ... ionError: Undefined  ...
                                    ^
             Differ at offset 18
  
  package:test_api                                          expect
  test/web.shard/expression_evaluation_web_test.dart 243:3  expectError
  test/web.shard/expression_evaluation_web_test.dart 192:3  evaluateErrorExpressions
  ===== asynchronous gap ===========================
  test/web.shard/expression_evaluation_web_test.dart 71:7   main.<fn>.<fn>

@zanderso
Copy link
Member Author

Changes in the roll https://dart.googlesource.com/sdk.git/+log/2a693f47e303..6fecad447467

/cc @johnniwinther @stefantsov

I don't know which of these it might have been:

https://dart.googlesource.com/sdk.git/+/1069cbe03c8cacd1e0b2c083f224817c807ff70f
https://dart.googlesource.com/sdk.git/+/b3af778a3833e9c636f7f8d558c8f57c25c42bc8

@zanderso
Copy link
Member Author

@annagrin for web expression evaluation test

@zanderso
Copy link
Member Author

Landing on red to help get rolls restarted.

@zanderso zanderso merged commit eaa9f8b into master Aug 25, 2021
@zanderso zanderso deleted the revert-28301-dart-sdk-flutter-engine-ff5cea59-27ff-4c1c-80fd-f593aa5a033d-1629904084 branch August 25, 2021 20:49
@johnniwinther
Copy link
Contributor

The errors come from https://dart.googlesource.com/sdk.git/+/b3af778a3833e9c636f7f8d558c8f57c25c42bc8 which improve the messages. @annagrin how can we update the tests so they match the new messages?

cbracken
cbracken reviewed Aug 25, 2021
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 25, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 25, 2021
@engine-flutter-autoroll
eaa9f8b Revert "Roll Dart SDK from 2a693f47e303 to 6fecad447467 (1 re…
c32bf61 
…vision) (flutter#28301)" (flutter/engine#28309)
@zanderso zanderso mentioned this pull request Aug 25, 2021
Closed
zanderso pushed a commit to flutter/flutter that referenced this pull request Aug 25, 2021
@engine-flutter-autoroll
Roll Engine from a9efb96 to eaa9f8b (25 revisions) (#88907)
f5dd3d9 
* f575a5d Roll Dart SDK from abecc4bc4521 to 72f462ed2d34 (6 revisions) (flutter/engine#28279)

* 25262ad Roll Skia from 0f36d11c1dcf to 6f90c702e6c8 (4 revisions) (flutter/engine#28280)

* 6c8ef61 Correct the return value of the method RunInIsolateScope (flutter/engine#28161)

* 2126214 Roll Skia from 6f90c702e6c8 to 877858a19502 (2 revisions) (flutter/engine#28282)

* 62934d0 Eliminate unnecessary null check in fixture (flutter/engine#28281)

* e218f5f Roll Skia from 877858a19502 to e43714f490ec (6 revisions) (flutter/engine#28283)

* b17c2a6 Roll Dart SDK from 72f462ed2d34 to 35c81c55d91f (1 revision) (flutter/engine#28284)

* bba6439 Roll Skia from e43714f490ec to 7b3edfa65923 (1 revision) (flutter/engine#28285)

* 902b16d Roll buildroot to 14b15b2 (flutter/engine#28286)

* 687affe hasStrings on Windows (flutter/engine#27749)

* 33342cb Roll Clang Mac from T2LfgbJBs... to XvHmkqWWH... (flutter/engine#28288)

* 5508373 Roll Clang Linux from cIFYQ49sp... to dO8igrHyL... (flutter/engine#28289)

* c2e289e Roll Skia from 7b3edfa65923 to 80fc31bc61a9 (2 revisions) (flutter/engine#28290)

* 1867ca4 Roll Dart SDK from 35c81c55d91f to 4c4bf41da092 (1 revision) (flutter/engine#28291)

* d75f033 Roll Skia from 80fc31bc61a9 to 9155b338bb9c (1 revision) (flutter/engine#28292)

* 9a2383c Roll Dart SDK from 4c4bf41da092 to 0507607e1380 (1 revision) (flutter/engine#28294)

* 16a94e6 Roll Skia from 9155b338bb9c to 02c7dac0be64 (1 revision) (flutter/engine#28295)

* 64891d0 Roll Skia from 02c7dac0be64 to 0305e86ee48c (1 revision) (flutter/engine#28296)

* 58b1b60 Roll Dart SDK from 0507607e1380 to 2a693f47e303 (1 revision) (flutter/engine#28297)

* 9c78284 Roll Skia from 0305e86ee48c to 1e16937f4734 (2 revisions) (flutter/engine#28300)

* 63f83fc Run the Android Robolectric tests using Gradle (flutter/engine#28084)

* 93f6188 Roll Dart SDK from 2a693f47e303 to 6fecad447467 (1 revision) (flutter/engine#28301)

* d6677ba Roll Skia from 1e16937f4734 to d34406abf959 (1 revision) (flutter/engine#28303)

* 6243b46 Roll Skia from d34406abf959 to b61014d31064 (5 revisions) (flutter/engine#28305)

* eaa9f8b Revert "Roll Dart SDK from 2a693f47e303 to 6fecad447467 (1 revision) (#28301)" (flutter/engine#28309)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@cbracken cbracken cbracken left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zanderso @johnniwinther @cbracken