Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Correct the return value of the method RunInIsolateScope #28161

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Correct the return value of the method RunInIsolateScope #28161

merged 1 commit into from
Aug 24, 2021

Conversation

@ColdPaleLight
Copy link
Member

@ColdPaleLight ColdPaleLight commented Aug 18, 2021 •
edited
Loading

I found that the return value of the method RunInIsolateScope was incorrect when I wrote a new test, , so I decided to fix it.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Aug 18, 2021
@Hixie
Copy link
Contributor

Hixie commented Aug 24, 2021

test-exempt: is a test

@jason-simmons jason-simmons added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Aug 24, 2021
@fluttergithubbot fluttergithubbot merged commit 6c8ef61 into flutter:master Aug 24, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 24, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 24, 2021
@engine-flutter-autoroll
6c8ef61 Correct the return value of the method RunInIsolateScope (flu…
c12cd80 
…tter/engine#28161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 24, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 24, 2021
@engine-flutter-autoroll
6c8ef61 Correct the return value of the method RunInIsolateScope (flu…
34b289f 
…tter/engine#28161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 24, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 24, 2021
@engine-flutter-autoroll
6c8ef61 Correct the return value of the method RunInIsolateScope (flu…
aed9d7c 
…tter/engine#28161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 25, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 25, 2021
@engine-flutter-autoroll
6c8ef61 Correct the return value of the method RunInIsolateScope (flu…
f9c208f 
…tter/engine#28161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 25, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 25, 2021
@engine-flutter-autoroll
6c8ef61 Correct the return value of the method RunInIsolateScope (flu…
69486dd 
…tter/engine#28161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 25, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 25, 2021
@engine-flutter-autoroll
6c8ef61 Correct the return value of the method RunInIsolateScope (flu…
ba4e506 
…tter/engine#28161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 25, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 25, 2021
@engine-flutter-autoroll
6c8ef61 Correct the return value of the method RunInIsolateScope (flu…
d7021cf 
…tter/engine#28161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 25, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 25, 2021
@engine-flutter-autoroll
6c8ef61 Correct the return value of the method RunInIsolateScope (flu…
85b9a42 
…tter/engine#28161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 25, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 25, 2021
@engine-flutter-autoroll
6c8ef61 Correct the return value of the method RunInIsolateScope (flu…
dcbf544 
…tter/engine#28161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 25, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 25, 2021
@engine-flutter-autoroll
6c8ef61 Correct the return value of the method RunInIsolateScope (flu…
6298495 
…tter/engine#28161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 25, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 25, 2021
@engine-flutter-autoroll
6c8ef61 Correct the return value of the method RunInIsolateScope (flu…
ef39eba 
…tter/engine#28161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 25, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 25, 2021
@engine-flutter-autoroll
6c8ef61 Correct the return value of the method RunInIsolateScope (flu…
b3e8944 
…tter/engine#28161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 25, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 25, 2021
@engine-flutter-autoroll
6c8ef61 Correct the return value of the method RunInIsolateScope (flu…
664c0d9 
…tter/engine#28161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 25, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 25, 2021
@engine-flutter-autoroll
6c8ef61 Correct the return value of the method RunInIsolateScope (flu…
cee6cff 
…tter/engine#28161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 25, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 25, 2021
@engine-flutter-autoroll
6c8ef61 Correct the return value of the method RunInIsolateScope (flu…
24331bb 
…tter/engine#28161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 25, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 25, 2021
@engine-flutter-autoroll
6c8ef61 Correct the return value of the method RunInIsolateScope (flu…
7717bd9 
…tter/engine#28161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 25, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 25, 2021
@engine-flutter-autoroll
6c8ef61 Correct the return value of the method RunInIsolateScope (flu…
a0d036d 
…tter/engine#28161)
zanderso pushed a commit to flutter/flutter that referenced this pull request Aug 25, 2021
@engine-flutter-autoroll
Roll Engine from a9efb96 to eaa9f8b (25 revisions) (#88907)
f5dd3d9 
* f575a5d Roll Dart SDK from abecc4bc4521 to 72f462ed2d34 (6 revisions) (flutter/engine#28279)

* 25262ad Roll Skia from 0f36d11c1dcf to 6f90c702e6c8 (4 revisions) (flutter/engine#28280)

* 6c8ef61 Correct the return value of the method RunInIsolateScope (flutter/engine#28161)

* 2126214 Roll Skia from 6f90c702e6c8 to 877858a19502 (2 revisions) (flutter/engine#28282)

* 62934d0 Eliminate unnecessary null check in fixture (flutter/engine#28281)

* e218f5f Roll Skia from 877858a19502 to e43714f490ec (6 revisions) (flutter/engine#28283)

* b17c2a6 Roll Dart SDK from 72f462ed2d34 to 35c81c55d91f (1 revision) (flutter/engine#28284)

* bba6439 Roll Skia from e43714f490ec to 7b3edfa65923 (1 revision) (flutter/engine#28285)

* 902b16d Roll buildroot to 14b15b2 (flutter/engine#28286)

* 687affe hasStrings on Windows (flutter/engine#27749)

* 33342cb Roll Clang Mac from T2LfgbJBs... to XvHmkqWWH... (flutter/engine#28288)

* 5508373 Roll Clang Linux from cIFYQ49sp... to dO8igrHyL... (flutter/engine#28289)

* c2e289e Roll Skia from 7b3edfa65923 to 80fc31bc61a9 (2 revisions) (flutter/engine#28290)

* 1867ca4 Roll Dart SDK from 35c81c55d91f to 4c4bf41da092 (1 revision) (flutter/engine#28291)

* d75f033 Roll Skia from 80fc31bc61a9 to 9155b338bb9c (1 revision) (flutter/engine#28292)

* 9a2383c Roll Dart SDK from 4c4bf41da092 to 0507607e1380 (1 revision) (flutter/engine#28294)

* 16a94e6 Roll Skia from 9155b338bb9c to 02c7dac0be64 (1 revision) (flutter/engine#28295)

* 64891d0 Roll Skia from 02c7dac0be64 to 0305e86ee48c (1 revision) (flutter/engine#28296)

* 58b1b60 Roll Dart SDK from 0507607e1380 to 2a693f47e303 (1 revision) (flutter/engine#28297)

* 9c78284 Roll Skia from 0305e86ee48c to 1e16937f4734 (2 revisions) (flutter/engine#28300)

* 63f83fc Run the Android Robolectric tests using Gradle (flutter/engine#28084)

* 93f6188 Roll Dart SDK from 2a693f47e303 to 6fecad447467 (1 revision) (flutter/engine#28301)

* d6677ba Roll Skia from 1e16937f4734 to d34406abf959 (1 revision) (flutter/engine#28303)

* 6243b46 Roll Skia from d34406abf959 to b61014d31064 (5 revisions) (flutter/engine#28305)

* eaa9f8b Revert "Roll Dart SDK from 2a693f47e303 to 6fecad447467 (1 revision) (#28301)" (flutter/engine#28309)
yx-mike added a commit to yx-mike/engine that referenced this pull request Dec 31, 2021
@yx-mike
Correct the return value of the method RunInIsolateScope (flutter#28161)
16945b5
yx-mike added a commit to yx-mike/engine that referenced this pull request Dec 31, 2021
@yx-mike
Revert "Correct the return value of the method RunInIsolateScope (flu…
253bf2d 
…tter#28161)"

This reverts commit 16945b5.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jason-simmons jason-simmons jason-simmons approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes customer: alibaba needs tests waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ColdPaleLight @Hixie @jason-simmons @fluttergithubbot