hasStrings on Windows #27749
hasStrings on Windows #27749
Conversation
justinmc
force-pushed
the
has-strings-windows
branch
from
6606f5f to
c9d633a
Compare
justinmc
force-pushed
the
has-strings-windows
branch
from
6703606 to
83af633
Compare
justinmc
force-pushed
the
has-strings-windows
branch
from
e9a558a to
b7c562e
Compare
| })); | ||
| } | ||
|
|
||
| TEST(PlatformHandler, HasStringsCallsThrough) { |
There was a problem hiding this comment.
I was NOT able to run these tests locally! Are we ok if the checks just pass here on Github? Which unittests.exe file in out/ is supposed to run the tests in this file? @dkwingsmt
There was a problem hiding this comment.
It should be flutter_windows_unittests but it looks like it was never actually added to the build. That would be good to fix in this PR.
Are we ok if the checks just pass here on Github?
In theory, but since it's missing from the build the GitHub checks aren't telling us anything.
There was a problem hiding this comment.
Ah, I felt like something was up. Thanks, I'll add it!
|
Let me know if I've missed anyone else that I should get to review this. |
AFAIK the plan of record is still to wrap all of the method channels in embedder APIs, it's just a matter of actually finding the time to do it. |
justinmc
force-pushed
the
has-strings-windows
branch
from
6f69f5c to
85528fd
Compare
|
I've gotten the tests to compile but they don't pass. Test output.\out\host_debug_unopt\flutter_windows_unittests.exe[INFO:test_timeout_listener.cc(76)] Test timeout of 30 seconds per test case will be enforced. [==========] Running 77 tests from 15 test suites. [----------] Global test environment set-up. [----------] 6 tests from StringConversion [ RUN ] StringConversion.Utf16FromUtf8Empty [ OK ] StringConversion.Utf16FromUtf8Empty (0 ms) [ RUN ] StringConversion.Utf16FromUtf8Ascii [ OK ] StringConversion.Utf16FromUtf8Ascii (0 ms) [ RUN ] StringConversion.Utf16FromUtf8Unicode [ OK ] StringConversion.Utf16FromUtf8Unicode (0 ms) [ RUN ] StringConversion.Utf8FromUtf16Empty [ OK ] StringConversion.Utf8FromUtf16Empty (0 ms) [ RUN ] StringConversion.Utf8FromUtf16Ascii [ OK ] StringConversion.Utf8FromUtf16Ascii (0 ms) [ RUN ] StringConversion.Utf8FromUtf16Unicode [ OK ] StringConversion.Utf8FromUtf16Unicode (0 ms) [----------] 6 tests from StringConversion (4 ms total) [----------] 1 test from PlatformHandler [ RUN ] PlatformHandler.GettingTextCallsThrough Assertion failed: IsString(), file ../../third_party/rapidjson/include\rapidjson/document.h, line 1773 |
|
@justinmc Are you blocked on this? |
|
@chinmaygarde Yes, I'm struggling to get those old tests to pass now that they've been added to the build. I've pinged @clarkezone for advice. |
* f575a5d Roll Dart SDK from abecc4bc4521 to 72f462ed2d34 (6 revisions) (flutter/engine#28279) * 25262ad Roll Skia from 0f36d11c1dcf to 6f90c702e6c8 (4 revisions) (flutter/engine#28280) * 6c8ef61 Correct the return value of the method RunInIsolateScope (flutter/engine#28161) * 2126214 Roll Skia from 6f90c702e6c8 to 877858a19502 (2 revisions) (flutter/engine#28282) * 62934d0 Eliminate unnecessary null check in fixture (flutter/engine#28281) * e218f5f Roll Skia from 877858a19502 to e43714f490ec (6 revisions) (flutter/engine#28283) * b17c2a6 Roll Dart SDK from 72f462ed2d34 to 35c81c55d91f (1 revision) (flutter/engine#28284) * bba6439 Roll Skia from e43714f490ec to 7b3edfa65923 (1 revision) (flutter/engine#28285) * 902b16d Roll buildroot to 14b15b2 (flutter/engine#28286) * 687affe hasStrings on Windows (flutter/engine#27749) * 33342cb Roll Clang Mac from T2LfgbJBs... to XvHmkqWWH... (flutter/engine#28288) * 5508373 Roll Clang Linux from cIFYQ49sp... to dO8igrHyL... (flutter/engine#28289) * c2e289e Roll Skia from 7b3edfa65923 to 80fc31bc61a9 (2 revisions) (flutter/engine#28290) * 1867ca4 Roll Dart SDK from 35c81c55d91f to 4c4bf41da092 (1 revision) (flutter/engine#28291) * d75f033 Roll Skia from 80fc31bc61a9 to 9155b338bb9c (1 revision) (flutter/engine#28292) * 9a2383c Roll Dart SDK from 4c4bf41da092 to 0507607e1380 (1 revision) (flutter/engine#28294) * 16a94e6 Roll Skia from 9155b338bb9c to 02c7dac0be64 (1 revision) (flutter/engine#28295) * 64891d0 Roll Skia from 02c7dac0be64 to 0305e86ee48c (1 revision) (flutter/engine#28296) * 58b1b60 Roll Dart SDK from 0507607e1380 to 2a693f47e303 (1 revision) (flutter/engine#28297) * 9c78284 Roll Skia from 0305e86ee48c to 1e16937f4734 (2 revisions) (flutter/engine#28300) * 63f83fc Run the Android Robolectric tests using Gradle (flutter/engine#28084) * 93f6188 Roll Dart SDK from 2a693f47e303 to 6fecad447467 (1 revision) (flutter/engine#28301) * d6677ba Roll Skia from 1e16937f4734 to d34406abf959 (1 revision) (flutter/engine#28303) * 6243b46 Roll Skia from d34406abf959 to b61014d31064 (5 revisions) (flutter/engine#28305) * eaa9f8b Revert "Roll Dart SDK from 2a693f47e303 to 6fecad447467 (1 revision) (#28301)" (flutter/engine#28309)
7 participants
Implements the hasStrings method for the Windows platform. This allows the framework to check if the clipboard has content without accessing the content itself on platforms that show a notification to the user when the clipboard is read. Here on Windows I don't believe it shows a notification anyway, but it's good to not read the clipboard when we don't have to.
Related Issues
Main issue: flutter/flutter#60145
hasStrings iOS: #19859
hasStrings Android: #20393
hasStrings Mac: #20531
hasStrings Linux: #21388
hasStrings framework: flutter/flutter#61774, flutter/flutter#87678