Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jul 28, 2021

Let's see if the new Xcode bundle no longer crashes this test. Hope springs eternal.

Also unskip tests that look like they were mistakenly never on? #26185
Fixes flutter/flutter#74267

@jmagman jmagman added platform-ios affects: tests tech-debt Technical debt, code quality, testing, etc. labels Jul 28, 2021
@jmagman jmagman self-assigned this Jul 28, 2021
@google-cla google-cla bot added the cla: yes label Jul 28, 2021
@jmagman jmagman requested a review from zanderso July 29, 2021 01:13
@chinmaygarde chinmaygarde added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 29, 2021
@fluttergithubbot fluttergithubbot merged commit e224b27 into flutter:master Jul 29, 2021
@jmagman jmagman deleted the skip-url branch July 29, 2021 20:24
zanderso added a commit that referenced this pull request Jul 29, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 29, 2021
zanderso added a commit that referenced this pull request Jul 30, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2021
@jmagman jmagman mentioned this pull request Aug 3, 2021
8 tasks
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

affects: tests cla: yes platform-ios tech-debt Technical debt, code quality, testing, etc. waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

testLaunchUrl has become flaky

4 participants