This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Unskip iOS launch URL tests #27854
Merged
Unskip iOS launch URL tests #27854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
force-pushed
the
run-ios-unit-tests
branch
from
b3a7339 to
bfc4b99
Compare
jmagman
commented
Aug 3, 2021
| 0AC232F424BA71D300A85907 /* SemanticsObjectTest.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = SemanticsObjectTest.mm; sourceTree = "<group>"; }; | ||
| 0AC232F724BA71D300A85907 /* FlutterEngineTest.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = FlutterEngineTest.mm; sourceTree = "<group>"; }; | ||
| 0AC2330324BA71D300A85907 /* accessibility_bridge_test.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = accessibility_bridge_test.mm; sourceTree = "<group>"; }; | ||
| 0AC2330B24BA71D300A85907 /* FlutterTextInputPluginTest.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = FlutterTextInputPluginTest.m; sourceTree = "<group>"; }; |
There was a problem hiding this comment.
FlutterTextInputPluginTest.m didn't exist.
| 0AC2331024BA71D300A85907 /* connection_collection_test.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = connection_collection_test.mm; sourceTree = "<group>"; }; | ||
| 0AC2331224BA71D300A85907 /* FlutterEnginePlatformViewTest.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = FlutterEnginePlatformViewTest.mm; sourceTree = "<group>"; }; | ||
| 0AC2331924BA71D300A85907 /* FlutterPluginAppLifeCycleDelegateTest.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = FlutterPluginAppLifeCycleDelegateTest.m; sourceTree = "<group>"; }; | ||
| 0AC2331924BA71D300A85907 /* FlutterPluginAppLifeCycleDelegateTest.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = FlutterPluginAppLifeCycleDelegateTest.mm; sourceTree = "<group>"; }; |
There was a problem hiding this comment.
FlutterPluginAppLifeCycleDelegateTest.m didn't exist.
jmagman
force-pushed
the
run-ios-unit-tests
branch
from
bfc4b99 to
9b10021
Compare
gaaclarke
approved these changes
Aug 4, 2021
shell/platform/darwin/ios/framework/Source/FlutterAppDelegateTest.mm
Outdated
Show resolved
Hide resolved
jmagman
force-pushed
the
run-ios-unit-tests
branch
from
9b10021 to
b79335b
Compare
jmagman
added
the
waiting for tree to go green
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 5, 2021
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Apr 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#27777 turned these back on, but they were failing with the log:
The dealloced instance was the block passed into the
-[FlutterEngine waitForFirstFrame::]stub. Pull it into a strong local to retain it until the end of scope (the test uses ARC).Minor Xcode project file cleanup.
Fixes flutter/flutter#74267
Pre-launch Checklist
writing and running engine tests.
///).