Deeplink URI fragment on Android and iOS #26185

nstrelow · 2021-05-16T22:40:14Z

Currently the URI fragment of a deeplink is ignored. This adds the URI fragment to the URI send to Flutter as well.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.
The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

google-cla · 2021-05-16T22:40:22Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

nstrelow · 2021-05-16T22:42:38Z

@googlebot I signed it!

nstrelow · 2021-07-10T16:12:27Z

@chunhtai Thanks to your pointers I was able to add support for deeplink URI fragments.

If you have time, I would love if you could review this or somebody else who is responsible.

If something is missing or needs changing, I will tend to it ASAP.

chunhtai

Sorry for getting back to the pr so late, I added some comments

shell/platform/android/io/flutter/embedding/android/FlutterActivityAndFragmentDelegate.java

...atform/android/test/io/flutter/embedding/android/FlutterActivityAndFragmentDelegateTest.java

shell/platform/darwin/ios/framework/Source/FlutterAppDelegate.mm

shell/platform/darwin/ios/framework/Source/FlutterAppDelegateTest.mm

flutterflakybot

LGTM

chunhtai

LGTM

* a7b5522 refactor and simplify CI dart analysis (flutter/engine#27370) * 137009b Switch test_suites to yaml. (flutter/engine#27368) * a22a3ca [web] fix a few analysis lints (flutter/engine#27375) * a02c017 make it work on <API 24 (flutter/engine#27398) * 0220256 Make FlutterFragment usable without requiring it to be attached to an Android Activity. (Attempt 2) (flutter/engine#27397) * 51e07a5 [fuchsia] Use FFI to get System clockMonotonic (flutter/engine#27353) * 4015d8b Roll Skia from 224e3e257d06 to 773a0b8c7e74 (44 revisions) (flutter/engine#27399) * 7db1a96 [ci.yaml] Add Linux Android Scenarios postsubmit (flutter/engine#27400) * a02f6bc remove the use of package:isolate (flutter/engine#27401) * 3237f4f Roll Skia from 773a0b8c7e74 to 36c1804e8f5c (1 revision) (flutter/engine#27402) * 75af7c8 Roll Dart SDK from ab009483f343 to 746879714c96 (5 revisions) (flutter/engine#27403) * be21e40 [ci.yaml] Add linux benchmarks, add enabled branches (flutter/engine#27405) * c8d7a97 Roll Fuchsia Mac SDK from wUg-tGGCL... to uhahzGJ6H... (flutter/engine#27408) * 3649200 Roll Skia from 36c1804e8f5c to 947a2eb3c043 (7 revisions) (flutter/engine#27410) * f04d941 [web] enable always_specify_types lint (flutter/engine#27406) * bdaaa4f [fuchsia] fix race in DefaultSessionConnection (flutter/engine#27377) * 84247f2 Update the Fuchsia runner to use fpromise instead of fit::promise (flutter/engine#27416) * 39119d2 Roll Skia from 947a2eb3c043 to 9081276b2907 (6 revisions) (flutter/engine#27426) * 9002bc7 Roll Skia from 9081276b2907 to 0547b914f691 (2 revisions) (flutter/engine#27430) * 58e0688 Roll Fuchsia Linux SDK from hykYtaK7D... to s2vrjrfuS... (flutter/engine#27431) * 1dca887 Roll Dart SDK from 746879714c96 to d53eb1066384 (2 revisions) (flutter/engine#27432) * c9008f3 Use python to run firebase testlab, do not expect recipe to know location of APK (flutter/engine#27434) * 8f7c529 Roll Skia from 0547b914f691 to 7d336c9557bd (3 revisions) (flutter/engine#27436) * 534404e Roll Fuchsia Mac SDK from uhahzGJ6H... to TWPguQ-ow... (flutter/engine#27438) * 9f13308 Roll Dart SDK from d53eb1066384 to fcbaa0a90b4b (1 revision) (flutter/engine#27439) * e5e7b94 Roll Skia from 7d336c9557bd to 7dc26fadc90b (2 revisions) (flutter/engine#27440) * bf3d265 Roll Skia from 7dc26fadc90b to dd561d021470 (1 revision) (flutter/engine#27442) * 6e62915 [ci.yaml] Add xcode property to ci.yaml (flutter/engine#27415) * 33c17a1 Roll Skia from dd561d021470 to 0e99fbe5da5c (1 revision) (flutter/engine#27443) * 0bc2479 Adjust web_sdk rule deps (flutter/engine#27435) * 7a8969a [web] enable prefer_final_locals lint (flutter/engine#27420) * 590902b Roll Dart SDK from fcbaa0a90b4b to 207232b5abe0 (1 revision) (flutter/engine#27446) * 283a42f fuchsia: Log vsync stats in inspect (flutter/engine#27433) * 4af14b9 Deeplink URI fragment on Android and iOS (flutter/engine#26185) * 47899db Remove unused generate_dart_ui target (flutter/engine#27445) * fb265c2 Roll Skia from 0e99fbe5da5c to a2d22b2e085e (3 revisions) (flutter/engine#27447) * 8bb5760 [ci.yaml] Mark Linux Android Scenarios as flaky (flutter/engine#27422)

…with mobile when handling fragments See also: flutter/engine#26185

flutter-dashboard bot added platform-android platform-ios labels May 16, 2021

google-cla bot added the cla: no label May 16, 2021

nstrelow changed the title ~~Deeplink fragment~~ Deeplink URI fragment on ANdroid and iOS May 16, 2021

nstrelow changed the title ~~Deeplink URI fragment on ANdroid and iOS~~ Deeplink URI fragment on Android and iOS May 16, 2021

google-cla bot added cla: yes and removed cla: no labels May 16, 2021

nstrelow force-pushed the deeplink-fragment branch 2 times, most recently from 74c7ec0 to 250aecf Compare July 10, 2021 15:30

nstrelow added 2 commits July 10, 2021 17:38

iOS deeplink sends fragment as well

263525b

Android deeplink sends fragment as well

23cf9be

nstrelow force-pushed the deeplink-fragment branch from 250aecf to 23cf9be Compare July 10, 2021 15:38

nstrelow marked this pull request as ready for review July 10, 2021 16:12

chunhtai self-requested a review July 11, 2021 19:08

nstrelow mentioned this pull request Jul 14, 2021

Android/iOS deeplink not working due to URI fragment supabase/supabase-flutter#3

Closed

chunhtai reviewed Jul 14, 2021

View reviewed changes

nstrelow added 2 commits July 15, 2021 18:45

Rename pathAndQueryAndFragment -> fullRoute

4af603c

Add test cases for with and without fragment

d0319b9

nstrelow force-pushed the deeplink-fragment branch from d298d4f to d0319b9 Compare July 15, 2021 16:46

flutterflakybot approved these changes Jul 15, 2021

View reviewed changes

chunhtai approved these changes Jul 15, 2021

View reviewed changes

chunhtai added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 15, 2021

fluttergithubbot merged commit 4af14b9 into flutter:master Jul 15, 2021

engine-flutter-autoroll mentioned this pull request Jul 15, 2021

Roll Engine from 093c4ed1a3d7 to 6491d17331ab (39 revisions) flutter/flutter#86505

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 15, 2021

4af14b9 Deeplink URI fragment on Android and iOS (flutter/engine#26185)

5dd56b1

engine-flutter-autoroll mentioned this pull request Jul 15, 2021

Roll Engine from 093c4ed1a3d7 to 8bb5760c0920 (37 revisions) flutter/flutter#86508

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 15, 2021

4af14b9 Deeplink URI fragment on Android and iOS (flutter/engine#26185)

0051ea5

jmagman mentioned this pull request Jul 28, 2021

Unskip iOS launch URL tests #27777

Merged

moffatman pushed a commit to moffatman/engine that referenced this pull request Aug 5, 2021

Deeplink URI fragment on Android and iOS (flutter#26185)

fa1ce26

naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021

Deeplink URI fragment on Android and iOS (flutter#26185)

17deddc

dsyrstad mentioned this pull request Mar 31, 2022

flutter_web_plugins PathUrlStrategy ignores fragments flutter/flutter#98933

Closed

clement9527 added a commit to clement9527/flutter that referenced this pull request Apr 26, 2022

Having the flutter web plugin PathUrlStrategy to behave consistently …

2ed9ee4

…with mobile when handling fragments See also: flutter/engine#26185

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Deeplink URI fragment on Android and iOS #26185

Deeplink URI fragment on Android and iOS #26185

Uh oh!

nstrelow commented May 16, 2021 •

edited

Loading

Uh oh!

google-cla bot commented May 16, 2021

Uh oh!

nstrelow commented May 16, 2021

Uh oh!

nstrelow commented Jul 10, 2021

Uh oh!

chunhtai left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

flutterflakybot left a comment

Uh oh!

chunhtai left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Deeplink URI fragment on Android and iOS #26185

Deeplink URI fragment on Android and iOS #26185

Uh oh!

Conversation

nstrelow commented May 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

google-cla bot commented May 16, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

nstrelow commented May 16, 2021

Uh oh!

nstrelow commented Jul 10, 2021

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

flutterflakybot left a comment

Choose a reason for hiding this comment

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nstrelow commented May 16, 2021 •

edited

Loading