-
Notifications
You must be signed in to change notification settings - Fork 6k
[flutter_releases] Flutter 1.26.0-17.2.pre Beta Engine Cherrypicks #24142
[flutter_releases] Flutter 1.26.0-17.2.pre Beta Engine Cherrypicks #24142
Conversation
|
(we might have missed your current batch) there was another bug with a cp request in flutter/flutter#72025 |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
1 similar comment
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
…sts (#23800) * [canvaskit] fix text background, foreground, familyFallback; add style tests * add leak test * update goldens_lock.yaml * remove solo * Warn when popping out of empty text style stack
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
1 similar comment
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
|
I manually updated the clabot status because all commit authors are Googlers. |
This Dart version contains the cherry pick for dart-lang/sdk#44822 (in dart-lang/sdk@e5dd92c) in Dart standalone. This Dart version will contain and flutter/engine#23954 (in flutter/engine#24142).
|
All checks were green, then I marked ready for review and they re-triggered. I will merge to be approved by @pcsosinski assuming they will go green again. |
|
|
This Dart version contains the cherry pick for dart-lang/sdk#44822 (in dart-lang/sdk@e5dd92c) in Dart standalone. This Dart version will contain and flutter/engine#23954 (in flutter/engine#24142).
Scheduled Cherrypicks
runesto get code units in CanvasKit. (#24024) #24144Infra Cherrypicks