Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Feb 2, 2021

Scheduled Cherrypicks

Infra Cherrypicks

  • This should be a no-op for Flutter apps that was cherry-picked to reduce merge conflicts.

@xster
Copy link
Member

xster commented Feb 2, 2021

(we might have missed your current batch) there was another bug with a cp request in flutter/flutter#72025

@google-cla
Copy link

google-cla bot commented Feb 2, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Feb 2, 2021
@christopherfujino christopherfujino changed the base branch from master to flutter-1.26-candidate.17 February 2, 2021 23:12
@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@christopherfujino christopherfujino changed the title [flutter_release] Flutter 1.26.0-17.2.pre Beta Engine Cherrypicks [flutter_releases] Flutter 1.26.0-17.2.pre Beta Engine Cherrypicks Feb 3, 2021
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Feb 3, 2021

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@christopherfujino
Copy link
Contributor Author

I manually updated the clabot status because all commit authors are Googlers.

dcharkes added a commit to dart-archive/ffi that referenced this pull request Feb 3, 2021
This Dart version contains the cherry pick for dart-lang/sdk#44822 (in dart-lang/sdk@e5dd92c) in Dart standalone.

This Dart version will contain and flutter/engine#23954 (in flutter/engine#24142).
@christopherfujino christopherfujino marked this pull request as ready for review February 3, 2021 20:02
@christopherfujino
Copy link
Contributor Author

christopherfujino commented Feb 3, 2021

All checks were green, then I marked ready for review and they re-triggered. I will merge to be approved by @pcsosinski assuming they will go green again.

@christopherfujino christopherfujino merged commit 2c527d6 into flutter:flutter-1.26-candidate.17 Feb 3, 2021
@christopherfujino christopherfujino deleted the cherrypicks-flutter-1.26-candidate.17 branch February 3, 2021 20:04
@christopherfujino
Copy link
Contributor Author

Mac beta Android Debug Engine Failed post-submit for infra reasons, a re-run passed.

dcharkes added a commit to dart-lang/native that referenced this pull request Jan 16, 2024
This Dart version contains the cherry pick for dart-lang/sdk#44822 (in dart-lang/sdk@e5dd92c) in Dart standalone.

This Dart version will contain and flutter/engine#23954 (in flutter/engine#24142).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants