Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Use runes to get code units in CanvasKit. #24024

Merged
merged 7 commits into from
Jan 29, 2021
Merged

Use runes to get code units in CanvasKit. #24024

merged 7 commits into from
Jan 29, 2021

Conversation

@harryterkelsen
Copy link
Contributor

@harryterkelsen harryterkelsen commented Jan 28, 2021 •
edited
Loading

Uses runes when iterating over a String's code points to get the actual code points, not surrogate pairs.

Fixes flutter/flutter#74823

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

yjbanov
yjbanov approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harryterkelsen harryterkelsen modified the milestone: 1.26 Jan 28, 2021
@chinmaygarde chinmaygarde added the platform-web Code specifically for the web engine label Jan 28, 2021
@harryterkelsen harryterkelsen added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 29, 2021
@harryterkelsen harryterkelsen added waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. and removed waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. labels Jan 29, 2021
@fluttergithubbot fluttergithubbot merged commit ed50eca into flutter:master Jan 29, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 29, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2021
@engine-flutter-autoroll
ed50eca Use runes to get code units in CanvasKit. (flutter/engine#2…
33d4627 
…4024)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 29, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2021
@engine-flutter-autoroll
ed50eca Use runes to get code units in CanvasKit. (flutter/engine#2…
2671995 
…4024)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 29, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2021
@engine-flutter-autoroll
ed50eca Use runes to get code units in CanvasKit. (flutter/engine#2…
330f731 
…4024)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 29, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2021
@engine-flutter-autoroll
ed50eca Use runes to get code units in CanvasKit. (flutter/engine#2…
9c7775d 
…4024)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 29, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2021
@engine-flutter-autoroll
ed50eca Use runes to get code units in CanvasKit. (flutter/engine#2…
d7b0b13 
…4024)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 29, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2021
@engine-flutter-autoroll
ed50eca Use runes to get code units in CanvasKit. (flutter/engine#2…
3e0a333 
…4024)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 29, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2021
@engine-flutter-autoroll
ed50eca Use runes to get code units in CanvasKit. (flutter/engine#2…
9b287a8 
…4024)
harryterkelsen pushed a commit to harryterkelsen/engine that referenced this pull request Feb 2, 2021
@harryterkelsen
Use runes to get code units in CanvasKit. (flutter#24024)
a56739c
harryterkelsen pushed a commit to harryterkelsen/engine that referenced this pull request Feb 2, 2021
@harryterkelsen
Use runes to get code units in CanvasKit. (flutter#24024)
09c4206
@harryterkelsen harryterkelsen mentioned this pull request Feb 2, 2021
Closed
9 tasks
christopherfujino added a commit that referenced this pull request Feb 3, 2021
@christopherfujino @dcharkes
@iskakaushik @xster @yjbanov @ferhatb @mdebbar
[flutter_releases] Flutter 1.26.0-17.2.pre Beta Engine Cherrypicks (#…
2c527d6 
…24142)

* add ffi_allocation_patch.dart to libraries.yaml 2 (#23954)

* Use `runes` to get code units in CanvasKit. (#24024)

* [windows] Honor only valid resize requests (#23990)

* Load FlutterLoader when creating FlutterEngineGroup (#23980)

* [canvaskit] remove the DOM node of unrendered platform view (#24001)

* update dart to 2.12.0-259.8.beta

* [web] Fix svg based stroke rendering. (#23969)

* [canvaskit] fix text background, foreground, color; add text style tests (#23800)

* [canvaskit] fix text background, foreground, familyFallback; add style tests

* add leak test

* update goldens_lock.yaml

* remove solo

* Warn when popping out of empty text style stack

* [web] Fix alignment issue in rich paragraphs (#23965)

* [web] Implement CanvasParagraph.getLineBoundary (#24037)

* [web] Fix text alignment when transform + tight constraints + DOM rendering (#24036)

* update licenses_third_party golden

Co-authored-by: Daco Harkes <[email protected]>
Co-authored-by: Harry Terkelsen <[email protected]>
Co-authored-by: Kaushik Iska <[email protected]>
Co-authored-by: xster <[email protected]>
Co-authored-by: Yegor <[email protected]>
Co-authored-by: Ferhat <[email protected]>
Co-authored-by: Mouad Debbar <[email protected]>
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@hjfreyer
Use runes to get code units in CanvasKit. (flutter#24024)
bfc317e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@yjbanov yjbanov yjbanov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-web Code specifically for the web engine waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Web CanvasKit] Emojis are not rendered and throwing an exception.

5 participants

@harryterkelsen @yjbanov @chinmaygarde @googlebot @fluttergithubbot