Load FlutterLoader when creating FlutterEngineGroup #23980
Conversation
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
Change looks good, I think we can do better with the DartEntrypoint API though. It's much easier on iOS because it accepts null to mean the default location. I know we don't want to use null so maybe we can make a const?
| engineGroupUnderTest.createAndRunEngine( | ||
| RuntimeEnvironment.application, | ||
| new DartEntrypoint( | ||
| FlutterInjector.instance().flutterLoader().findAppBundlePath(), |
There was a problem hiding this comment.
This is unfortunate, this is impossible to find for people that want to make a DartEntrypoint. Maybe we could add a const for it in the DartEntrypoint class? DartEntrypoint.DEFAULT_APP_BUNDLE_PATH? I couldn't find an example of anyone using the new API on github. It looks like a series of 2 changes have been deprecated and replaced for this.
There was a problem hiding this comment.
Totally agree. This API makes no sense lol. But that's a "new feature" and I want to cherry pick this. Left flutter/flutter#74828. Surprised no one complained yet :)
xster
added
the
waiting for tree to go green
|
Can't seem to retrigger the luci fuchsia test on head. Going to poke the infra with this PR. |
…24142) * add ffi_allocation_patch.dart to libraries.yaml 2 (#23954) * Use `runes` to get code units in CanvasKit. (#24024) * [windows] Honor only valid resize requests (#23990) * Load FlutterLoader when creating FlutterEngineGroup (#23980) * [canvaskit] remove the DOM node of unrendered platform view (#24001) * update dart to 2.12.0-259.8.beta * [web] Fix svg based stroke rendering. (#23969) * [canvaskit] fix text background, foreground, color; add text style tests (#23800) * [canvaskit] fix text background, foreground, familyFallback; add style tests * add leak test * update goldens_lock.yaml * remove solo * Warn when popping out of empty text style stack * [web] Fix alignment issue in rich paragraphs (#23965) * [web] Implement CanvasParagraph.getLineBoundary (#24037) * [web] Fix text alignment when transform + tight constraints + DOM rendering (#24036) * update licenses_third_party golden Co-authored-by: Daco Harkes <[email protected]> Co-authored-by: Harry Terkelsen <[email protected]> Co-authored-by: Kaushik Iska <[email protected]> Co-authored-by: xster <[email protected]> Co-authored-by: Yegor <[email protected]> Co-authored-by: Ferhat <[email protected]> Co-authored-by: Mouad Debbar <[email protected]>
2 participants
Fixes flutter/flutter#74767. Make the FlutterEngineGroup initialize the FlutterLoader. This is the same pattern as the FlutterEngine itself.
It's a breaking change though since I need to let the FlutterEngineGroup have a context too.