This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Placeholders for rich paragraphs #23160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdebbar
force-pushed
the
rich_placeholders
branch
from
4fb24b2 to
31e7be4
Compare
mdebbar
force-pushed
the
rich_placeholders
branch
from
31e7be4 to
05538c9
Compare
mdebbar
force-pushed
the
rich_placeholders
branch
from
05538c9 to
89c000e
Compare
ferhatb
approved these changes
Jan 6, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement placeholders for rich paragraphs.
Goldens PR: flutter/goldens#133
NOTE: This PR is supposed to be sent after #23136. But I'm sending it early to get reviews while I figure out the test failure in the other PR.
TO REVIEWERS: Please only look at the last commit. The other commits are part of another PR that will be landed separately.
Tests
Added several screenshot tests covering all possible alignments of placeholders.