Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 599a072

Browse files
authored
[web] Placeholders for rich paragraphs (#23160)
1 parent d38aac7 commit 599a072

File tree

6 files changed

+363
-65
lines changed

6 files changed

+363
-65
lines changed

lib/web_ui/dev/goldens_lock.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
repository: https://github.com/flutter/goldens.git
2-
revision: 4946ab2de031c14d30502efcaf51220e0be4d1f1
2+
revision: 7529e9018b11c79334b99d1e7343fcd500c77b08

lib/web_ui/lib/src/engine/text/canvas_paragraph.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,9 +170,7 @@ class CanvasParagraph implements EngineParagraph {
170170

171171
@override
172172
List<ui.TextBox> getBoxesForPlaceholders() {
173-
// TODO(mdebbar): After layout, placeholders positions should've been
174-
// determined and can be used to compute their boxes.
175-
return <ui.TextBox>[];
173+
return _layoutService.getBoxesForPlaceholders();
176174
}
177175

178176
// TODO(mdebbar): Check for child spans if any has styles that can't be drawn

0 commit comments

Comments
 (0)