Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/web_ui/dev/goldens_lock.yaml
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
repository: https://github.com/flutter/goldens.git
revision: 4946ab2de031c14d30502efcaf51220e0be4d1f1
revision: 7529e9018b11c79334b99d1e7343fcd500c77b08
4 changes: 1 addition & 3 deletions lib/web_ui/lib/src/engine/text/canvas_paragraph.dart
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,7 @@ class CanvasParagraph implements EngineParagraph {

@override
List<ui.TextBox> getBoxesForPlaceholders() {
// TODO(mdebbar): After layout, placeholders positions should've been
// determined and can be used to compute their boxes.
return <ui.TextBox>[];
return _layoutService.getBoxesForPlaceholders();
}

// TODO(mdebbar): Check for child spans if any has styles that can't be drawn
Expand Down
Loading