Skip to content

fix: JS and dart toString name conflict #10479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: JS and dart toString name conflict #10479

wants to merge 1 commit into from

Conversation

@PROGrand
Copy link

@PROGrand PROGrand commented Feb 16, 2023

ISSUE (up to flutter 3.7.3)

JavaScript toString conflict with dart toString, just use @js('toString') annotation.

@PROGrand PROGrand changed the title fix JS and dart toString name conflict [fix] JS and dart toString name conflict Feb 16, 2023
@PROGrand PROGrand changed the title [fix] JS and dart toString name conflict fix: JS and dart toString name conflict Feb 16, 2023
@Lyokone
Copy link
Contributor

Lyokone commented Feb 17, 2023

Fixed in #10476

@Lyokone Lyokone closed this Feb 17, 2023
@firebase firebase locked and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@joshuachestang joshuachestang joshuachestang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 Firebase Core & All Other Plugins :Uncaught (in promise) TypeError: Failed to resolve module specifier 'Instance of 'TrustedScriptURL''

3 participants

@PROGrand @Lyokone @joshuachestang