Skip to content

Conversation

@Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Feb 16, 2023

Description

Calling toString on the object would use the dart toString instead of the JS toString.
This fix will use the proper toString method.

We currently don't have the proper testing env for this. Should be investigated in another ticket.

Was manually tested.

Related Issues

closes #10474

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone merged commit 6388c62 into master Feb 17, 2023
@Lyokone Lyokone deleted the fix/10474 branch February 17, 2023 07:47
@firebase firebase locked and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [firebase_core] TypeError: Failed to resolve module specifier 'Instance of 'TrustedScriptURL''

3 participants