Skip to content

fix: JS and dart toString name conflict #10479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: JS and dart toString name conflict #10479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/firebase_core/firebase_core_web/lib/src/firebase_core_web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ class FirebaseCoreWeb extends FirebasePlatform {
script.crossOrigin = 'anonymous';
script.text = '''
window.ff_trigger_$windowVar = async (callback) => {
callback(await import("${trustedUrl?.toString() ?? src}"));
callback(await import("${trustedUrl?.toStringJS() ?? src}"));
};
''';

Expand Down
6 changes: 6 additions & 0 deletions packages/firebase_core/firebase_core_web/lib/src/interop/js.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,12 @@ extension DomTrustedTypePolicyExtension on DomTrustedTypePolicy {
@anonymous
abstract class DomTrustedScriptUrl {}

/// (Some) methods of the [DomTrustedScriptUrl]
extension DomTrustedScriptUrlExtension on DomTrustedScriptUrl {
@JS('toString')
external String toStringJS();
}

// Getters

/// window.trustedTypes (may or may not be supported by the browser)
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_core/firebase_core_web/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: firebase_core_web
description: The web implementation of firebase_core
homepage: https://github.com/firebase/flutterfire/tree/master/packages/firebase_core/firebase_core_web
repository: https://github.com/firebase/flutterfire/tree/master/packages/firebase_core/firebase_core_web
version: 2.2.0
version: 2.2.1

environment:
sdk: ">=2.16.0 <3.0.0"
Expand Down