Skip to content

Conversation

@dconeybe
Copy link
Contributor

@dconeybe dconeybe commented May 8, 2023

Sync spec tests with changes from firebase/firebase-js-sdk#7285: "Remove the no-android tag from bloom filter spec tests".

The changes in this PR have no effect on this SDK, but serves to keep the spec tests in sync for easier updating in the future.

#no-changelog

Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.08% (7453895) to 88.01% (91ffcb6) by -0.06%.

    FilenameBase (7453895)Merge (91ffcb6)Diff
    exception.cc84.21%23.68%-60.53%
    leveldb_key.cc98.14%98.82%+0.69%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XcKG8eYjzr.html

@dconeybe dconeybe merged commit cead230 into master May 8, 2023
@dconeybe dconeybe deleted the dconeybe/BloomFilterSpecTestsAndroidEnable branch May 8, 2023 22:10
@firebase firebase locked and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants