Firestore: Remove the no-android tag from bloom filter spec tests #7285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feature has been merged into the android sdk in firebase/firebase-android-sdk#4982
|
dconeybe
added a commit
to firebase/firebase-ios-sdk
that referenced
this pull request
May 8, 2023
Contributor
Size Report 1Affected ProductsNo changes between base commit (e45fea9) and merge commit (ddae56d).Test Logs |
Contributor
Size Analysis Report 1Affected ProductsNo changes between base commit (e45fea9) and merge commit (ddae56d).Test Logs |
Contributor
Size Analysis Report 1Affected ProductsNo changes between base commit (e45fea9) and merge commit (ddae56d).Test Logs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the no-android tag from bloom filter spec tests, now that the feature has been merged into the android sdk in firebase/firebase-android-sdk#4982.
The spec test changes from this PR were ported to the iOS SDK in firebase/firebase-ios-sdk#11245. Porting to the Android SDK is not needed since these changes were included in firebase/firebase-android-sdk#4982.