Skip to content

Firestore Spec Tests: Port JS PR 7285 (remove no-android tag from bloom filter tests) #11245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2023
Merged

Firestore Spec Tests: Port JS PR 7285 (remove no-android tag from bloom filter tests) #11245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 10 additions & 20 deletions Firestore/Example/Tests/SpecTests/json/existence_filter_spec_test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
"describeName": "Existence Filters:",
"itName": "Bloom filter can process special characters in document name",
"tags": [
"no-ios",
"no-android"
"no-ios"
],
"config": {
"numClients": 1,
Expand Down Expand Up @@ -208,8 +207,7 @@
"describeName": "Existence Filters:",
"itName": "Bloom filter fills in default values for undefined padding and hashCount",
"tags": [
"no-ios",
"no-android"
"no-ios"
],
"config": {
"numClients": 1,
Expand Down Expand Up @@ -396,8 +394,7 @@
"describeName": "Existence Filters:",
"itName": "Bloom filter is handled at global snapshot",
"tags": [
"no-ios",
"no-android"
"no-ios"
],
"config": {
"numClients": 1,
Expand Down Expand Up @@ -636,8 +633,7 @@
"describeName": "Existence Filters:",
"itName": "Bloom filter limbo resolution is denied",
"tags": [
"no-ios",
"no-android"
"no-ios"
],
"config": {
"numClients": 1,
Expand Down Expand Up @@ -897,8 +893,7 @@
"describeName": "Existence Filters:",
"itName": "Bloom filter with large size works as expected",
"tags": [
"no-ios",
"no-android"
"no-ios"
],
"config": {
"numClients": 1,
Expand Down Expand Up @@ -6522,8 +6517,7 @@
"describeName": "Existence Filters:",
"itName": "Full re-query is skipped when bloom filter can identify documents deleted",
"tags": [
"no-ios",
"no-android"
"no-ios"
],
"config": {
"numClients": 1,
Expand Down Expand Up @@ -6983,8 +6977,7 @@
"describeName": "Existence Filters:",
"itName": "Full re-query is triggered when bloom filter can not identify documents deleted",
"tags": [
"no-ios",
"no-android"
"no-ios"
],
"config": {
"numClients": 1,
Expand Down Expand Up @@ -7197,8 +7190,7 @@
"describeName": "Existence Filters:",
"itName": "Full re-query is triggered when bloom filter hashCount is invalid",
"tags": [
"no-ios",
"no-android"
"no-ios"
],
"config": {
"numClients": 1,
Expand Down Expand Up @@ -7387,8 +7379,7 @@
"describeName": "Existence Filters:",
"itName": "Full re-query is triggered when bloom filter is empty",
"tags": [
"no-ios",
"no-android"
"no-ios"
],
"config": {
"numClients": 1,
Expand Down Expand Up @@ -7577,8 +7568,7 @@
"describeName": "Existence Filters:",
"itName": "Same documents can have different bloom filters",
"tags": [
"no-ios",
"no-android"
"no-ios"
],
"config": {
"numClients": 1,
Expand Down
3 changes: 1 addition & 2 deletions Firestore/Example/Tests/SpecTests/json/limbo_spec_test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7956,8 +7956,7 @@
"describeName": "Limbo Documents:",
"itName": "Limbo resolution throttling with bloom filter application",
"tags": [
"no-ios",
"no-android"
"no-ios"
],
"config": {
"maxConcurrentLimboResolutions": 2,
Expand Down
9 changes: 3 additions & 6 deletions Firestore/Example/Tests/SpecTests/json/listen_spec_test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3385,8 +3385,7 @@
"describeName": "Listens:",
"itName": "ExpectedCount in listen request should work after coming back online",
"tags": [
"no-ios",
"no-android"
"no-ios"
],
"config": {
"numClients": 1,
Expand Down Expand Up @@ -12746,8 +12745,7 @@
"describeName": "Listens:",
"itName": "Resuming a query should specify expectedCount that does not include pending mutations",
"tags": [
"no-ios",
"no-android"
"no-ios"
],
"config": {
"numClients": 1,
Expand Down Expand Up @@ -12949,8 +12947,7 @@
"describeName": "Listens:",
"itName": "Resuming a query should specify expectedCount when adding the target",
"tags": [
"no-ios",
"no-android"
"no-ios"
],
"config": {
"numClients": 1,
Expand Down