[ML] Preserve alias attributes when making them hidden #80346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
droberts195
approved these changes
Nov 4, 2021
droberts195
left a comment
droberts195
left a comment
There was a problem hiding this comment.
LGTM apart from one debugging leftover.
But before you merge this please can you run a few more iterations of BWC on #79123 with the continue condition that I messed up corrected. Then we can be sure that the code really does work when upgrading a real 6.8 cluster to 7.16.
.../src/javaRestTest/java/org/elasticsearch/xpack/ml/integration/MlInitializationServiceIT.java
Outdated
Show resolved
Hide resolved
Contributor
Author
Sure, will do. |
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Nov 5, 2021
przemekwitek
added a commit
that referenced
this pull request
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #77416.
If aliases on ML hidden indices are made hidden then
all attributes of the alias need to be preserved.
The particularly critical case for ML is where a job's
results alias has a filter that restricts documents
returned when searching the shared results index to
those that relate to the job.