[ML] Make ML indices hidden when the node becomes master #77416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
przemekwitek
force-pushed
the
make_indices_hidden
branch
5 times, most recently
from
e2d5bd7 to
7954500
Compare
przemekwitek
force-pushed
the
make_indices_hidden
branch
from
7954500 to
d4269fd
Compare
przemekwitek
changed the title
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
droberts195
reviewed
Sep 16, 2021
x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MachineLearning.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MlInitializationService.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MlInitializationService.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MlInitializationService.java
Outdated
Show resolved
Hide resolved
przemekwitek
force-pushed
the
make_indices_hidden
branch
3 times, most recently
from
3c3e2b5 to
5564011
Compare
przemekwitek
force-pushed
the
make_indices_hidden
branch
3 times, most recently
from
dcf5457 to
fd2a606
Compare
przemekwitek
commented
Oct 5, 2021
Contributor
Author
przemekwitek
left a comment
przemekwitek
left a comment
There was a problem hiding this comment.
Aliases are now made hidden too.
PTAL
droberts195
reviewed
Oct 5, 2021
droberts195
left a comment
droberts195
left a comment
There was a problem hiding this comment.
It looks like there might be a couple of things left over from debugging, and I also left a couple of comments about logging.
x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MachineLearning.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MlInitializationService.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MlInitializationService.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MlInitializationService.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MlInitializationService.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MlInitializationService.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MlInitializationService.java
Outdated
Show resolved
Hide resolved
przemekwitek
force-pushed
the
make_indices_hidden
branch
from
0bd9b35 to
27631e0
Compare
droberts195
approved these changes
Oct 7, 2021
x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MlInitializationService.java
Outdated
Show resolved
Hide resolved
…hidden to execute
…tate when the aliases are made hidden
przemekwitek
force-pushed
the
make_indices_hidden
branch
from
cd1b2b1 to
b11436a
Compare
Contributor
Author
|
run elasticsearch-ci/part-1 |
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Oct 11, 2021
* upstream/master: (250 commits) [Transform] HLRC cleanups (elastic#78909) [ML] Make ML indices hidden when the node becomes master (elastic#77416) Introduce a Few Settings Singleton Instances (elastic#78897) Simplify TestCluster extraJar configuration (elastic#78837) Add @OverRide annotations to methods in EnrichPlugin class (elastic#76873) Add v7 restCompat for invalidating API key with the id field (elastic#78664) EQL: Refine repeatable queries (elastic#78895) Fix DataTierTests package and add a validation test (elastic#78880) Fix split package org.elasticsearch.common.xcontent (elastic#78831) Store DataTier Preference directly on IndexMetadata (elastic#78668) [DOCS] Fixes typo in calendar API example (elastic#78867) Improve Node Shutdown Observability (elastic#78727) Convert encrypted snapshot license object to LicensedFeature (elastic#78731) Revert "Make nodePaths() singular (elastic#72514)" (elastic#78801) Fix incorrect generic type in PolicyStepsRegistry (elastic#78628) [DOCS] Fixes ML get calendars API (elastic#78808) Implement GET API for System Feature Upgrades (elastic#78642) [TEST] More MetadataStateFormat tests (elastic#78577) Add support for rest compatibility headers to the HLRC (elastic#78490) Un-ignoring tests after backporting fix (elastic#78830) ... # Conflicts: # server/src/main/java/org/elasticsearch/ingest/IngestService.java # server/src/test/java/org/elasticsearch/ingest/IngestServiceTests.java
droberts195
pushed a commit
to droberts195/elasticsearch
that referenced
this pull request
Nov 1, 2021
This is a followup to elastic#77416. If aliases on ML hidden indices are made hidden then all attributes of the alias need to be preserved. The particularly critical case for ML is where a job's results alias has a filter that restricts documents returned when searching the shared results index to those that relate to the job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the ML indices hidden when the node becomes master.
The affected ML indices are:
.ml-anomalies-*,.ml-state*,.ml-stats-*,.ml-notifications*,.ml-annotations*.This change is needed because these indices could have been created before the notion of the hidden index was introduced.
Relates #53674