[ML] Preserve alias attributes when making them hidden #80148
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a followup to elastic#77416. If aliases on ML hidden indices are made hidden then all attributes of the alias need to be preserved. The particularly critical case for ML is where a job's results alias has a filter that restricts documents returned when searching the shared results index to those that relate to the job.
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
przemekwitek
reviewed
Nov 4, 2021
| indicesAliasesRequest.addAliasAction( | ||
| IndicesAliasesRequest.AliasActions.add() | ||
| for (AliasMetadata existingAliasMetadata : entry.value) { | ||
| if (existingAliasMetadata.isHidden() == null || existingAliasMetadata.isHidden() == false) { |
Contributor
There was a problem hiding this comment.
FYI: This condition must be reversed. I did that in my PR (#80346) which replaces this one.
Author
There was a problem hiding this comment.
Oh dear. I think that invalidates the testing we did on #79123. Please could reopen that PR, apply the fix, and run a few more BWC test jobs that will do real upgrades of 6.8 to 7.16. Assuming they all work that PR can then be closed again.
This was my mistake. Sorry for the inconvenience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #77416.
If aliases on ML hidden indices are made hidden then
all attributes of the alias need to be preserved.
The particularly critical case for ML is where a job's
results alias has a filter that restricts documents
returned when searching the shared results index to
those that relate to the job.