Add max_single_primary_size as a condition for the rollover index API #67842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It had no non-test callers, so YAGNI.
to separate the building of a Conditition.Stats cleanly from the evaluation of same.
joegallo
added
the
:Data Management/Indices APIs
elasticmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
dakrone
reviewed
Jan 21, 2021
Member
dakrone
left a comment
dakrone
left a comment
There was a problem hiding this comment.
I left some minor comments, but this looks great!
...rest-high-level/src/main/java/org/elasticsearch/client/indices/rollover/RolloverRequest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/admin/indices/rollover/RolloverRequest.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/org/elasticsearch/action/admin/indices/rollover/RolloverRequestBuilder.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/elasticsearch/action/admin/indices/rollover/TransportRolloverAction.java
Outdated
Show resolved
Hide resolved
Just a copy/paste + search&replace on 30_max_size_condition.yml, nothing special.
It's just a copy/paste/edit of testRolloverMaxSize, but it's still got some value.
This comment has been minimized.
This comment has been minimized.
joegallo
force-pushed
the
rollover-max-single-shard-size
branch
from
56c4b2a to
70ed3e1
Compare
dakrone
approved these changes
Feb 3, 2021
Member
dakrone
left a comment
dakrone
left a comment
There was a problem hiding this comment.
LGTM, thanks for iterating on this!
Contributor
Author
|
Thanks for iterating with me! |
This was referenced Feb 3, 2021
joegallo
added a commit
that referenced
this pull request
Feb 4, 2021
This was referenced Feb 18, 2021
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #63026
This PR ignores ILM and any deprecation that we might end up doing. It's just adding a new feature, the ability to specify
max_single_primary_sizeas a condition for the_rolloverAPI.Note: I still have some docs and test changes to get in, but this is probably 90% done and would be okay to review.