-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[7.x] Add max_single_primary_size as a condition for the rollover index API #68489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.x] Add max_single_primary_size as a condition for the rollover index API #68489
Conversation
|
Pinging @elastic/es-core-features (Team:Core/Features) |
| } | ||
| } | ||
|
|
||
| // helper because java 8 doesn't have Optional.stream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not enormously thrilled about this, but 🤷.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do what we can with Java 8, this looks reasonable though.
| --- | ||
| "Rollover with max_single_primary_size condition": | ||
| - skip: | ||
| version: " - 7.11.99" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double check my brain on this one bit here -- is this the right version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is the right version
Related to #63026, backport of #67842