Skip to content

Conversation

@joegallo
Copy link
Contributor

See #63026 (comment). max_primary_shard_size does indeed seem like a better name than max_single_primary_size to me.

Changes the naming from as added in #67705, #67842, and #68917. This'll need backporting to 7.x and 7.12.

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Feb 18, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

When we merge this to master and 7.x, we'll need bwc off. Once we get
backported to 7.12, though, then we can ride up the line re-enabling
bwc without any attendant version changes.
@joegallo joegallo requested a review from jakelandis February 18, 2021 23:45
@joegallo
Copy link
Contributor Author

joegallo commented Feb 18, 2021

I think I got 'em all:

joegallo@galactic:~/Code/elastic/elasticsearch $ git checkout master
Your branch is up to date with 'upstream/master'.
joegallo@galactic:~/Code/elastic/elasticsearch $ git grep -E -i '(max_single_primary_size|maxsingleprimarysize|max single)' | wc -l
     311
joegallo@galactic:~/Code/elastic/elasticsearch $ git checkout rename-max-single-primary-size
Switched to branch 'rename-max-single-primary-size'
Your branch is up to date with 'origin/rename-max-single-primary-size'.
joegallo@galactic:~/Code/elastic/elasticsearch $ git grep -E -i '(max_single_primary_size|maxsingleprimarysize|max single)' | wc -l
       0

Copy link
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A quick visual inspection shows no changes but the name and correct spellings. Also, thanks for the grep output comment.

@joegallo
Copy link
Contributor Author

BWC tests re-enabled in #69252.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/ILM+SLM Index and Snapshot lifecycle management >non-issue Team:Data Management Meta label for data/management team v7.12.0 v7.13.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants