Skip to content

Conversation

@nknize
Copy link
Contributor

@nknize nknize commented Aug 8, 2019

This PR adds the following:

  1. x-pack spatial plugin
  2. new ShapeFieldMapper for indexing general cartesian geometries based on Lucene's new XYShape field type
  3. new ShapeQueryBuilder for building lucene queries that search indexed XYShape fields

This feature is added by backporting the following PRs: #44389, #44923, #44980, and #45108

Docs for how to index and search the new shape field type are added, along with tests for both the new ShapeFieldMapper and ShapeQueryBuilder.

talevy and others added 4 commits August 8, 2019 17:08
This commit introduces a skeleton Spatial plugin that will be filled-in
with some new licensed features coming to Geo/Spatial land!
…lastic#44923)

Refactors DeprecatedParameters specific to legacy geo_shape out of
AbstractGeometryFieldMapper.TypeParser#parse.
…stic#44980)

This commit adds a new ShapeFieldMapper to the xpack spatial module for
indexing arbitrary cartesian geometries using a new field type called shape.
The indexing approach leverages lucene's new XYShape field type which is
backed by BKD in the same manner as LatLonShape but without the WGS84
latitude longitude restrictions. The new field mapper builds on and
extends the refactoring effort in AbstractGeometryFieldMapper and accepts
shapes in either GeoJSON or WKT format (both of which support non geospatial
geometries).

Tests are provided in the ShapeFieldMapperTest class in the same manner
as GeoShapeFieldMapperTests and LegacyGeoShapeFieldMapperTests.
Documentation for how to use the new field type and what parameters are
accepted is included. The QueryBuilder for searching indexed shapes is
provided in a separate commit.
…ry (elastic#45108)

This commit adds a new ShapeQueryBuilder to the xpack spatial module for
querying arbitrary Cartesian geometries indexed using the new shape field
type.

The query builder extends AbstractGeometryQueryBuilder and leverages the
ShapeQueryProcessor added in the previous field mapper commit.

Tests are provided in ShapeQueryTests in the same manner as
GeoShapeQueryTests and docs are updated to explain how the query works.
@nknize nknize added >feature release highlight :Analytics/Geo Indexing, search aggregations of geo points and shapes backport v7.4.0 labels Aug 8, 2019
@nknize nknize requested review from imotov and talevy August 8, 2019 22:47
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo

@nknize nknize requested a review from polyfractal August 8, 2019 22:53
@nknize
Copy link
Contributor Author

nknize commented Aug 14, 2019

@imotov This should be good to go in order to clear the way for #45332

Copy link
Contributor

@imotov imotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nknize nknize merged commit 647a830 into elastic:7.x Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/Geo Indexing, search aggregations of geo points and shapes backport >feature release highlight v7.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants