Introduce Spatial Plugin #44389
Merged
Introduce Spatial Plugin #44389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a skeleton Geo plugin that will be filled-in with some new licensed features coming to Geo!
talevy
added
>non-issue
:Analytics/Geo
Collaborator
|
Pinging @elastic/es-analytics-geo |
talevy
commented
Jul 15, 2019
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/XPackSettings.java
Outdated
Show resolved
Hide resolved
Contributor
|
just a generic question: Is this really Geo or should be called Spatial? My point here is that if in this package we will introduce XYShape as well, then Geo is too specific. |
Contributor
Author
|
@iverase that is a good point, I think that may be the better name. I'll check with some others as well |
Contributor
Author
|
run elasticsearch-ci/1 |
imotov
reviewed
Jul 16, 2019
rjernst
reviewed
Jul 17, 2019
Member
rjernst
left a comment
rjernst
left a comment
There was a problem hiding this comment.
I don't think we need the "enabled"? We recently added voting-only without it, and I don't htink it is necessary for most things.
Contributor
Author
|
thanks Ryan, mind taking another look? |
nknize
pushed a commit
to nknize/elasticsearch
that referenced
this pull request
Aug 8, 2019
This commit introduces a skeleton Spatial plugin that will be filled-in with some new licensed features coming to Geo/Spatial land!
nknize
added a commit
that referenced
this pull request
Aug 14, 2019
…45363) * Introduce Spatial Plugin (#44389) Introduce a skeleton Spatial plugin that holds new licensed features coming to Geo/Spatial land! * [GEO] Refactor DeprecatedParameters in AbstractGeometryFieldMapper (#44923) Refactor DeprecatedParameters specific to legacy geo_shape out of AbstractGeometryFieldMapper.TypeParser#parse. * [SPATIAL] New ShapeFieldMapper for indexing cartesian geometries (#44980) Add a new ShapeFieldMapper to the xpack spatial module for indexing arbitrary cartesian geometries using a new field type called shape. The indexing approach leverages lucene's new XYShape field type which is backed by BKD in the same manner as LatLonShape but without the WGS84 latitude longitude restrictions. The new field mapper builds on and extends the refactoring effort in AbstractGeometryFieldMapper and accepts shapes in either GeoJSON or WKT format (both of which support non geospatial geometries). Tests are provided in the ShapeFieldMapperTest class in the same manner as GeoShapeFieldMapperTests and LegacyGeoShapeFieldMapperTests. Documentation for how to use the new field type and what parameters are accepted is included. The QueryBuilder for searching indexed shapes is provided in a separate commit. * [SPATIAL] New ShapeQueryBuilder for querying indexed cartesian geometry (#45108) Add a new ShapeQueryBuilder to the xpack spatial module for querying arbitrary Cartesian geometries indexed using the new shape field type. The query builder extends AbstractGeometryQueryBuilder and leverages the ShapeQueryProcessor added in the previous field mapper commit. Tests are provided in ShapeQueryTests in the same manner as GeoShapeQueryTests and docs are updated to explain how the query works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a skeleton xpack Spatial plugin that will be filled-in
with some new licensed features coming to Geo-Spatial!
This will just be merged into
master, until the first feature merged in the spatial pluginwill be merged. Then we can back-port this PR to 7.x prior to merging in any future 7x features