Geo: Change order of parameter in Geometries to lon, lat #45332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the order of parameters in Geometries from lat, lon to lon, lat and moves all Geometry classes are moved to the org.elasticsearch.geomtery package. Closes elastic#45048
imotov
added
>enhancement
:Analytics/Geo
Collaborator
|
Pinging @elastic/es-analytics-geo |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample |
nknize
approved these changes
Aug 8, 2019
Contributor
nknize
left a comment
nknize
left a comment
There was a problem hiding this comment.
This is great.. gives a nice consistency w/ the new shape field. I like that we can use either get{X,Y,Z} or get{Lat, Lon, Alt} in the API.
Contributor
Author
|
Backport depends on #45363 |
imotov
added a commit
to imotov/elasticsearch
that referenced
this pull request
Aug 15, 2019
Changes the order of parameters in Geometries from lat, lon to lon, lat and moves all Geometry classes are moved to the org.elasticsearch.geomtery package. Backport of elastic#45332 Closes elastic#45048
imotov
added a commit
that referenced
this pull request
Aug 16, 2019
Contributor
|
It looks like the backporting is complete here so I have removed the backport pending label while generating 7.4.0 release notes. Please let me know if this is wrong |
Contributor
Author
|
@colings86 yes, I forgot to circle back here and remove the label. Thanks! |
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the order of parameters in Geometries from lat, lon to lon, lat
and moves all Geometry classes are moved to the
org.elasticsearch.geomtery package.
Closes #45048