Rolling Upgrade Fixes Backport 6.x #35532
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
original-brownbear
added
>test
Collaborator
|
Pinging @elastic/es-distributed |
original-brownbear
changed the title
Contributor
Author
|
Jenkins test this |
* For `6.5+` use file based discovery in REST tests * Relates elastic#33675
* DISCOVERY: Fix RollingUpgradeTests * Don't manually manage min master nodes if not necessary * Remove some dead code * Allow for manually supplying list of seed nodes * Closes elastic#35178
* DISCOVERY: 0s Initial State Timeout in Tests * Don't wait for initial state even with a single node, otherwise the loop writing the discovery file causes that single node to wait for its own transport.ports file for 30s. * Closes elastic#35456
original-brownbear
force-pushed
the
rolling-upgrade-fixes
branch
from
5e4cca3 to
ae6bf36
Compare
Contributor
Author
|
Jenkins test this |
1 similar comment
Contributor
Author
|
Jenkins test this |
alpar-t
reviewed
Nov 14, 2018
buildSrc/src/main/groovy/org/elasticsearch/gradle/test/ClusterFormationTasks.groovy
Outdated
Show resolved
Hide resolved
alpar-t
reviewed
Nov 14, 2018
| } | ||
| dependsOn = startDependencies | ||
| } else { | ||
| dependsOn = startTasks.empty ? startDependencies : startTasks.get(0) |
Contributor
There was a problem hiding this comment.
Can you explain why we are picking up these dependencies on older versions only ?
Contributor
Author
There was a problem hiding this comment.
Yea, this is because we don't have the file based discovery in the main codebase in earlier versions so we don't use it.
Contributor
Author
|
Jenkins test this |
* REST-Tests: Use Dedicated AntBuilders * Use dedicated AntBuilder everywhere since AntBuilder is not threadsafe * Closes elastic#33778
* MINOR: Remove SNAPSHOT Suffixes in Gradle * The snapshot qualifiers here are redundant and 6.5.0 is released anyway
Contributor
Author
|
closing here, I pushed these commits straight to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just opening a PR to run Jenkins on these